From: Javier Martinez Canillas <javierm@redhat.com>
To: Marcus Folkesson <marcus.folkesson@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Marcus Folkesson <marcus.folkesson@gmail.com>
Subject: Re: [PATCH RESEND v2 5/6] drm/sitronix/st7571: split up the driver into a common and an i2c part
Date: Mon, 15 Dec 2025 10:11:44 +0100 [thread overview]
Message-ID: <87345ckt2n.fsf@ocarina.mail-host-address-is-not-set> (raw)
In-Reply-To: <20251202-st7571-split-v2-5-1e537a09e92f@gmail.com>
Marcus Folkesson <marcus.folkesson@gmail.com> writes:
> Split up the driver to make it possible to add support for hw interfaces
> other than I2C.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
[...]
> +config DRM_ST7571_I2C
> + tristate "DRM support for Sitronix ST7567/ST7571 display panels (I2C)"
> + depends on DRM_ST7571 && I2C
> + select REGMAP_I2C
I think this should only be "select REGMAP", since you are not using the
REGMAP I2C support but instead have your own regmap write callback (due
the need to I2C_M_IGNORE_NAK).
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2025-12-15 9:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 8:25 [PATCH RESEND v2 0/6] drm/sitronix/st7571: split up driver to support both I2C and SPI Marcus Folkesson
2025-12-02 8:25 ` [PATCH RESEND v2 1/6] drm/sitronix/st7571-i2c: rename 'struct drm_device' in st7571_device Marcus Folkesson
2025-12-14 11:12 ` Javier Martinez Canillas
2025-12-02 8:25 ` [PATCH RESEND v2 2/6] drm/sitronix/st7571-i2c: add 'struct device' to st7571_device Marcus Folkesson
2025-12-14 11:15 ` Javier Martinez Canillas
2025-12-02 8:25 ` [PATCH RESEND v2 3/6] drm/sitronix/st7571-i2c: move common structures to st7571.h Marcus Folkesson
2025-12-14 11:20 ` Javier Martinez Canillas
2025-12-02 8:25 ` [PATCH RESEND v2 4/6] drm/sitronix/st7571-i2c: make probe independent of hw interface Marcus Folkesson
2025-12-15 9:02 ` Javier Martinez Canillas
2025-12-02 8:25 ` [PATCH RESEND v2 5/6] drm/sitronix/st7571: split up the driver into a common and an i2c part Marcus Folkesson
2025-12-15 9:11 ` Javier Martinez Canillas [this message]
2025-12-02 8:25 ` [PATCH RESEND v2 6/6] drm/sitronix/st7571-spi: add support for SPI interface Marcus Folkesson
2025-12-15 9:20 ` Javier Martinez Canillas
-- strict thread matches above, loose matches on Subject: below --
2025-11-17 9:03 [PATCH RESEND v2 0/6] drm/sitronix/st7571: split up driver to support both I2C and SPI Marcus Folkesson
2025-11-17 9:03 ` [PATCH RESEND v2 5/6] drm/sitronix/st7571: split up the driver into a common and an i2c part Marcus Folkesson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87345ckt2n.fsf@ocarina.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marcus.folkesson@gmail.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®