* [PATCH] selftests/filesystems: Add six consecutive 'x' characters to mktemp
@ 2023-07-18 3:43 Hui Min Mina Chou
2023-07-18 6:31 ` Javier Martinez Canillas
0 siblings, 1 reply; 3+ messages in thread
From: Hui Min Mina Chou @ 2023-07-18 3:43 UTC (permalink / raw)
To: hirofumi, shuah, javierm
Cc: linux-kselftest, linux-kernel, tim609, dylan, az70021, minachou
In busybox, the mktemp requires that the generated filename be
suffixed with at least six consecutive 'X' characters. Otherwise,
it will return an "Invalid argument" error.
Signed-off-by: Hui Min Mina Chou <minachou@andestech.com>
---
tools/testing/selftests/filesystems/fat/run_fat_tests.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/filesystems/fat/run_fat_tests.sh b/tools/testing/selftests/filesystems/fat/run_fat_tests.sh
index 7f35dc3d15df..d61264d4795d 100755
--- a/tools/testing/selftests/filesystems/fat/run_fat_tests.sh
+++ b/tools/testing/selftests/filesystems/fat/run_fat_tests.sh
@@ -12,7 +12,7 @@ set -u
set -o pipefail
BASE_DIR="$(dirname $0)"
-TMP_DIR="$(mktemp -d /tmp/fat_tests_tmp.XXXX)"
+TMP_DIR="$(mktemp -d /tmp/fat_tests_tmp.XXXXXX)"
IMG_PATH="${TMP_DIR}/fat.img"
MNT_PATH="${TMP_DIR}/mnt"
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] selftests/filesystems: Add six consecutive 'x' characters to mktemp
2023-07-18 3:43 [PATCH] selftests/filesystems: Add six consecutive 'x' characters to mktemp Hui Min Mina Chou
@ 2023-07-18 6:31 ` Javier Martinez Canillas
2023-08-16 16:12 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Javier Martinez Canillas @ 2023-07-18 6:31 UTC (permalink / raw)
To: Hui Min Mina Chou, hirofumi, shuah
Cc: linux-kselftest, linux-kernel, tim609, dylan, az70021, minachou
Hui Min Mina Chou <minachou@andestech.com> writes:
> In busybox, the mktemp requires that the generated filename be
> suffixed with at least six consecutive 'X' characters. Otherwise,
> it will return an "Invalid argument" error.
>
> Signed-off-by: Hui Min Mina Chou <minachou@andestech.com>
> ---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/filesystems: Add six consecutive 'x' characters to mktemp
2023-07-18 6:31 ` Javier Martinez Canillas
@ 2023-08-16 16:12 ` Shuah Khan
0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2023-08-16 16:12 UTC (permalink / raw)
To: Javier Martinez Canillas, Hui Min Mina Chou, hirofumi, shuah
Cc: linux-kselftest, linux-kernel, tim609, dylan, az70021, Shuah Khan
On 7/18/23 00:31, Javier Martinez Canillas wrote:
> Hui Min Mina Chou <minachou@andestech.com> writes:
>
>> In busybox, the mktemp requires that the generated filename be
>> suffixed with at least six consecutive 'X' characters. Otherwise,
>> it will return an "Invalid argument" error.
>>
>> Signed-off-by: Hui Min Mina Chou <minachou@andestech.com>
>> ---
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
>
Applied to linux-kselftest next for Linux 6.6-rc1.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-16 16:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-18 3:43 [PATCH] selftests/filesystems: Add six consecutive 'x' characters to mktemp Hui Min Mina Chou
2023-07-18 6:31 ` Javier Martinez Canillas
2023-08-16 16:12 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®