* [PATCH] x86/boot/compressed/64: Drop the now-unused finalize_identity_maps()
@ 2020-11-13 15:08 Vitaly Kuznetsov
2020-11-13 15:13 ` Arvind Sankar
0 siblings, 1 reply; 3+ messages in thread
From: Vitaly Kuznetsov @ 2020-11-13 15:08 UTC (permalink / raw)
To: x86
Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, H. Peter Anvin,
Joerg Roedel, Arvind Sankar, linux-kernel
Since commit 8570978ea030 ("x86/boot/compressed/64: Don't pre-map memory in
KASLR code") finalize_identity_maps() has no users, drop it.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
arch/x86/boot/compressed/ident_map_64.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/arch/x86/boot/compressed/ident_map_64.c b/arch/x86/boot/compressed/ident_map_64.c
index a5e5db6ada3c..6bf20223dc0f 100644
--- a/arch/x86/boot/compressed/ident_map_64.c
+++ b/arch/x86/boot/compressed/ident_map_64.c
@@ -167,16 +167,6 @@ void initialize_identity_maps(void *rmode)
write_cr3(top_level_pgt);
}
-/*
- * This switches the page tables to the new level4 that has been built
- * via calls to add_identity_map() above. If booted via startup_32(),
- * this is effectively a no-op.
- */
-void finalize_identity_maps(void)
-{
- write_cr3(top_level_pgt);
-}
-
static pte_t *split_large_pmd(struct x86_mapping_info *info,
pmd_t *pmdp, unsigned long __address)
{
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86/boot/compressed/64: Drop the now-unused finalize_identity_maps()
2020-11-13 15:08 [PATCH] x86/boot/compressed/64: Drop the now-unused finalize_identity_maps() Vitaly Kuznetsov
@ 2020-11-13 15:13 ` Arvind Sankar
2020-11-13 15:39 ` Vitaly Kuznetsov
0 siblings, 1 reply; 3+ messages in thread
From: Arvind Sankar @ 2020-11-13 15:13 UTC (permalink / raw)
To: Vitaly Kuznetsov
Cc: x86, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
H. Peter Anvin, Joerg Roedel, Arvind Sankar, linux-kernel
On Fri, Nov 13, 2020 at 04:08:10PM +0100, Vitaly Kuznetsov wrote:
> Since commit 8570978ea030 ("x86/boot/compressed/64: Don't pre-map memory in
> KASLR code") finalize_identity_maps() has no users, drop it.
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> arch/x86/boot/compressed/ident_map_64.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/x86/boot/compressed/ident_map_64.c b/arch/x86/boot/compressed/ident_map_64.c
> index a5e5db6ada3c..6bf20223dc0f 100644
> --- a/arch/x86/boot/compressed/ident_map_64.c
> +++ b/arch/x86/boot/compressed/ident_map_64.c
> @@ -167,16 +167,6 @@ void initialize_identity_maps(void *rmode)
> write_cr3(top_level_pgt);
> }
>
> -/*
> - * This switches the page tables to the new level4 that has been built
> - * via calls to add_identity_map() above. If booted via startup_32(),
> - * this is effectively a no-op.
> - */
> -void finalize_identity_maps(void)
> -{
> - write_cr3(top_level_pgt);
> -}
> -
> static pte_t *split_large_pmd(struct x86_mapping_info *info,
> pmd_t *pmdp, unsigned long __address)
> {
> --
> 2.26.2
>
I had sent this and another unused removal last month:
https://lore.kernel.org/lkml/20201005151208.2212886-1-nivedita@alum.mit.edu/
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86/boot/compressed/64: Drop the now-unused finalize_identity_maps()
2020-11-13 15:13 ` Arvind Sankar
@ 2020-11-13 15:39 ` Vitaly Kuznetsov
0 siblings, 0 replies; 3+ messages in thread
From: Vitaly Kuznetsov @ 2020-11-13 15:39 UTC (permalink / raw)
To: Arvind Sankar
Cc: x86, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
H. Peter Anvin, Joerg Roedel, Arvind Sankar, linux-kernel
Arvind Sankar <nivedita@alum.mit.edu> writes:
> On Fri, Nov 13, 2020 at 04:08:10PM +0100, Vitaly Kuznetsov wrote:
>> Since commit 8570978ea030 ("x86/boot/compressed/64: Don't pre-map memory in
>> KASLR code") finalize_identity_maps() has no users, drop it.
>>
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>> ---
>> arch/x86/boot/compressed/ident_map_64.c | 10 ----------
>> 1 file changed, 10 deletions(-)
>>
>> diff --git a/arch/x86/boot/compressed/ident_map_64.c b/arch/x86/boot/compressed/ident_map_64.c
>> index a5e5db6ada3c..6bf20223dc0f 100644
>> --- a/arch/x86/boot/compressed/ident_map_64.c
>> +++ b/arch/x86/boot/compressed/ident_map_64.c
>> @@ -167,16 +167,6 @@ void initialize_identity_maps(void *rmode)
>> write_cr3(top_level_pgt);
>> }
>>
>> -/*
>> - * This switches the page tables to the new level4 that has been built
>> - * via calls to add_identity_map() above. If booted via startup_32(),
>> - * this is effectively a no-op.
>> - */
>> -void finalize_identity_maps(void)
>> -{
>> - write_cr3(top_level_pgt);
>> -}
>> -
>> static pte_t *split_large_pmd(struct x86_mapping_info *info,
>> pmd_t *pmdp, unsigned long __address)
>> {
>> --
>> 2.26.2
>>
>
> I had sent this and another unused removal last month:
> https://lore.kernel.org/lkml/20201005151208.2212886-1-nivedita@alum.mit.edu/
>
Ah, no problem, let this serve as a gentle ping to the maintainers then)
--
Vitaly
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-13 15:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 15:08 [PATCH] x86/boot/compressed/64: Drop the now-unused finalize_identity_maps() Vitaly Kuznetsov
2020-11-13 15:13 ` Arvind Sankar
2020-11-13 15:39 ` Vitaly Kuznetsov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome