From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: lsr@neapel230.server4you.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] Manually inline shortname_info_to_lcase()
Date: Wed, 10 Nov 2004 00:11:29 +0900 [thread overview]
Message-ID: <873bzj5a72.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20041109014358.GE6835@neapel230.server4you.de> (lsr@neapel230.server4you.de's message of "Tue, 9 Nov 2004 02:43:58 +0100")
lsr@neapel230.server4you.de writes:
> @@ -447,20 +431,22 @@
> if (is_shortname && base_info.valid && ext_info.valid) {
> if (vfat_find_form(dir, name_res) == 0)
> return -EEXIST;
>
> if (opt_shortname & VFAT_SFN_CREATE_WIN95) {
> return (base_info.upper && ext_info.upper);
> } else if (opt_shortname & VFAT_SFN_CREATE_WINNT) {
> if ((base_info.upper || base_info.lower)
> && (ext_info.upper || ext_info.lower)) {
> - *lcase = shortname_info_to_lcase(&base_info,
> - &ext_info);
> + if (!base_info.upper && base_info.lower)
> + *lcase |= CASE_LOWER_BASE;
> + if (!ext_info.upper && ext_info.lower)
> + *lcase |= CASE_LOWER_EXT;
Looks good. Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2004-11-09 16:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-09 1:30 [PATCH 0/4] VFAT cleanup Rene Scharfe
2004-11-09 1:35 ` [PATCH 1/4] Move check for invalid chars to vfat_valid_longname() lsr
2004-11-09 15:03 ` OGAWA Hirofumi
2004-11-09 16:22 ` René Scharfe
2004-11-09 17:25 ` OGAWA Hirofumi
2004-11-09 18:22 ` Rene Scharfe
2004-11-09 18:41 ` OGAWA Hirofumi
2004-11-09 1:38 ` [PATCH 2/4] Return better error codes from vfat_valid_longname() lsr
2004-11-09 15:28 ` OGAWA Hirofumi
2004-11-09 16:49 ` Rene Scharfe
2004-11-09 17:35 ` OGAWA Hirofumi
2004-11-09 18:35 ` Rene Scharfe
2004-11-09 19:08 ` OGAWA Hirofumi
2004-11-09 1:42 ` [PATCH 3/4] Simplify checks for unwanted chars lsr
2004-11-09 15:40 ` OGAWA Hirofumi
2004-11-09 1:43 ` [PATCH 4/4] Manually inline shortname_info_to_lcase() lsr
2004-11-09 15:11 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873bzj5a72.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=lsr@neapel230.server4you.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome