mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] Move check for invalid chars to vfat_valid_longname()
Date: Wed, 10 Nov 2004 03:41:32 +0900	[thread overview]
Message-ID: <874qjylvab.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20041109182224.GA15288@neapel230.server4you.de> (Rene Scharfe's message of "Tue, 9 Nov 2004 19:22:24 +0100")

Rene Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> But doesn't imply this we can't do any of our checks on the VFS
> string?

Basically yes.

> A dot (0x2E) at the end of a filename could be the half of some other
> character in some encoding, right?

'.'/' ' is not contained as second byte by any encodings, at least
current nls is supporting encodings.

> And the same could be said about the checks in
> vfat_valid_longname(), no?

These are string, not char. These should be unique.

> The patch you asked for converting IS_BADCHAR to an inline function
> follows. I rolled it together with the other conversions from patch 3.
> Applies directly on top of 2.6.10-rc1-bk18.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2004-11-09 18:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-09  1:30 [PATCH 0/4] VFAT cleanup Rene Scharfe
2004-11-09  1:35 ` [PATCH 1/4] Move check for invalid chars to vfat_valid_longname() lsr
2004-11-09 15:03   ` OGAWA Hirofumi
2004-11-09 16:22     ` René Scharfe
2004-11-09 17:25       ` OGAWA Hirofumi
2004-11-09 18:22         ` Rene Scharfe
2004-11-09 18:41           ` OGAWA Hirofumi [this message]
2004-11-09  1:38 ` [PATCH 2/4] Return better error codes from vfat_valid_longname() lsr
2004-11-09 15:28   ` OGAWA Hirofumi
2004-11-09 16:49     ` Rene Scharfe
2004-11-09 17:35       ` OGAWA Hirofumi
2004-11-09 18:35         ` Rene Scharfe
2004-11-09 19:08           ` OGAWA Hirofumi
2004-11-09  1:42 ` [PATCH 3/4] Simplify checks for unwanted chars lsr
2004-11-09 15:40   ` OGAWA Hirofumi
2004-11-09  1:43 ` [PATCH 4/4] Manually inline shortname_info_to_lcase() lsr
2004-11-09 15:11   ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874qjylvab.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rene.scharfe@lsrfire.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome