[PATCH] arm64: dts: qcom: monaco: Enable cpufreq cooling devices

[PATCH] arm64: dts: qcom: monaco: Enable cpufreq cooling devices

[Gaurav Kohli]

Add cooling-cells property to the CPU nodes to support cpufreq
cooling devices.

Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/monaco.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
index 816fa2af8a9a..caac947efa34 100644
--- a/arch/arm64/boot/dts/qcom/monaco.dtsi
+++ b/arch/arm64/boot/dts/qcom/monaco.dtsi
@@ -55,6 +55,7 @@ cpu0: cpu@0 {
 			power-domain-names = "psci";
 			capacity-dmips-mhz = <1946>;
 			dynamic-power-coefficient = <472>;
+			#cooling-cells = <2>;
 			qcom,freq-domain = <&cpufreq_hw 0>;
 			operating-points-v2 = <&cpu0_opp_table>;
 			interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
@@ -79,6 +80,7 @@ cpu1: cpu@100 {
 			power-domains = <&cpu_pd1>;
 			power-domain-names = "psci";
 			capacity-dmips-mhz = <1946>;
+			#cooling-cells = <2>;
 			dynamic-power-coefficient = <472>;
 			qcom,freq-domain = <&cpufreq_hw 0>;
 			operating-points-v2 = <&cpu0_opp_table>;
@@ -104,6 +106,7 @@ cpu2: cpu@200 {
 			power-domains = <&cpu_pd2>;
 			power-domain-names = "psci";
 			capacity-dmips-mhz = <1946>;
+			#cooling-cells = <2>;
 			dynamic-power-coefficient = <507>;
 			qcom,freq-domain = <&cpufreq_hw 2>;
 			operating-points-v2 = <&cpu2_opp_table>;
@@ -129,6 +132,7 @@ cpu3: cpu@300 {
 			power-domains = <&cpu_pd3>;
 			power-domain-names = "psci";
 			capacity-dmips-mhz = <1946>;
+			#cooling-cells = <2>;
 			dynamic-power-coefficient = <507>;
 			qcom,freq-domain = <&cpufreq_hw 2>;
 			operating-points-v2 = <&cpu2_opp_table>;
@@ -154,6 +158,7 @@ cpu4: cpu@10000 {
 			power-domains = <&cpu_pd4>;
 			power-domain-names = "psci";
 			capacity-dmips-mhz = <1024>;
+			#cooling-cells = <2>;
 			dynamic-power-coefficient = <100>;
 			qcom,freq-domain = <&cpufreq_hw 1>;
 			operating-points-v2 = <&cpu4_opp_table>;
@@ -179,6 +184,7 @@ cpu5: cpu@10100 {
 			power-domains = <&cpu_pd5>;
 			power-domain-names = "psci";
 			capacity-dmips-mhz = <1024>;
+			#cooling-cells = <2>;
 			dynamic-power-coefficient = <100>;
 			qcom,freq-domain = <&cpufreq_hw 1>;
 			operating-points-v2 = <&cpu4_opp_table>;
@@ -204,6 +210,7 @@ cpu6: cpu@10200 {
 			power-domains = <&cpu_pd6>;
 			power-domain-names = "psci";
 			capacity-dmips-mhz = <1024>;
+			#cooling-cells = <2>;
 			dynamic-power-coefficient = <100>;
 			qcom,freq-domain = <&cpufreq_hw 1>;
 			operating-points-v2 = <&cpu4_opp_table>;
@@ -229,6 +236,7 @@ cpu7: cpu@10300 {
 			power-domains = <&cpu_pd7>;
 			power-domain-names = "psci";
 			capacity-dmips-mhz = <1024>;
+			#cooling-cells = <2>;
 			dynamic-power-coefficient = <100>;
 			qcom,freq-domain = <&cpufreq_hw 1>;
 			operating-points-v2 = <&cpu4_opp_table>;
-- 
2.34.1

Re: [PATCH] arm64: dts: qcom: monaco: Enable cpufreq cooling devices

[Dmitry Baryshkov]

On Mon, Dec 08, 2025 at 05:15:58PM +0530, Gaurav Kohli wrote:
> Add cooling-cells property to the CPU nodes to support cpufreq
> cooling devices.
> 
> Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/monaco.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Are there any cooling maps to be defined?

-- 
With best wishes
Dmitry

Re: [PATCH] arm64: dts: qcom: monaco: Enable cpufreq cooling devices

[Gaurav Kohli]

On 12/10/2025 1:38 AM, Dmitry Baryshkov wrote:
> Are there any cooling maps to be defined?


We need it to configure from userspace daemon.


thanks

Gaurav

Re: [PATCH] arm64: dts: qcom: monaco: Enable cpufreq cooling devices

[Dmitry Baryshkov]

On Wed, Dec 10, 2025 at 12:37:05PM +0530, Gaurav Kohli wrote:
> 
> On 12/10/2025 1:38 AM, Dmitry Baryshkov wrote:
> > Are there any cooling maps to be defined?
> 
> 
> We need it to configure from userspace daemon.

You are describing behaviour. Please describe the hardware instead.

-- 
With best wishes
Dmitry

Re: [PATCH] arm64: dts: qcom: monaco: Enable cpufreq cooling devices

[Gaurav Kohli]

On 12/10/2025 1:45 PM, Dmitry Baryshkov wrote:
> On Wed, Dec 10, 2025 at 12:37:05PM +0530, Gaurav Kohli wrote:
>> On 12/10/2025 1:38 AM, Dmitry Baryshkov wrote:
>>> Are there any cooling maps to be defined?
>>
>> We need it to configure from userspace daemon.
> You are describing behaviour. Please describe the hardware instead.


you mean without defining cooling map for cpu, we should not add 
cooling-cells to cpu?

thanks
Gaurav

Re: [PATCH] arm64: dts: qcom: monaco: Enable cpufreq cooling devices

[Dmitry Baryshkov]

On Thu, Dec 11, 2025 at 04:45:11PM +0530, Gaurav Kohli wrote:
> 
> On 12/10/2025 1:45 PM, Dmitry Baryshkov wrote:
> > On Wed, Dec 10, 2025 at 12:37:05PM +0530, Gaurav Kohli wrote:
> > > On 12/10/2025 1:38 AM, Dmitry Baryshkov wrote:
> > > > Are there any cooling maps to be defined?
> > > 
> > > We need it to configure from userspace daemon.
> > You are describing behaviour. Please describe the hardware instead.
> 
> 
> you mean without defining cooling map for cpu, we should not add
> cooling-cells to cpu?

Looking at other platforms:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH] arm64: dts: qcom: monaco: Enable cpufreq cooling devices

[Bjorn Andersson]

On Mon, 08 Dec 2025 17:15:58 +0530, Gaurav Kohli wrote:
> Add cooling-cells property to the CPU nodes to support cpufreq
> cooling devices.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: monaco: Enable cpufreq cooling devices
      commit: 0f15cbbf315c12a9c1004196d5beed8cce9dcf6d

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>