mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] perf tools: Use per-file CFLAGS in Makefile
Date: Mon, 23 Sep 2013 18:17:09 +0900	[thread overview]
Message-ID: <874n9brj6y.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20130921124714.GA8304@krava.brq.redhat.com> (Jiri Olsa's message of "Sat, 21 Sep 2013 14:47:14 +0200")

Hi Jiri,

On Sat, 21 Sep 2013 14:47:14 +0200, Jiri Olsa wrote:
> On Mon, Sep 16, 2013 at 11:11:16AM +0900, Namhyung Kim wrote:
>> From: Namhyung Kim <namhyung.kim@lge.com>
>> 
>> Some files need additional compiler flags to be built successfully.
>> Cleanup Makefile by using optional per-file CFLAGS which look like
>> CFLAGS_dir_filename.o
>
> I like it, but I'm getting following error:
>
>   $ make 
>       ...
>       AR libperf.a
>   ar: util/rbtree.o: No such file or directory
>   make: *** [libperf.a] Error 1
>   $
>
> probably because rbtree object is based in kernel lib
>
>
> Also this patch collides with your previous:
>   perf tools: Separate out GTK codes to libperf-gtk.so
>
> which I needed to revert first to get this one applied.

Thanks for the feedback.  I'll take a look and fix them.

Thanks,
Namhyung

      reply	other threads:[~2013-09-23  9:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-16  2:11 Namhyung Kim
2013-09-20 23:01 ` Borislav Petkov
2013-09-23  9:15   ` Namhyung Kim
2013-09-23  9:26     ` Borislav Petkov
2013-09-24  8:09       ` Namhyung Kim
2013-09-24 17:08         ` Arnaldo Carvalho de Melo
2013-09-27  0:38           ` Namhyung Kim
2013-09-21 12:47 ` Jiri Olsa
2013-09-23  9:17   ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874n9brj6y.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=bp@alien8.de \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®