* [PATCH] tools lib traceevent: test correct variable after allocation
@ 2012-12-21 20:00 Sasha Levin
2012-12-26 4:28 ` Namhyung Kim
2013-01-25 11:25 ` [tip:perf/core] " tip-bot for Sasha Levin
0 siblings, 2 replies; 3+ messages in thread
From: Sasha Levin @ 2012-12-21 20:00 UTC (permalink / raw)
To: Namhyung Kim, Steven Rostedt, Arnaldo Carvalho de Melo,
Frederic Weisbecker, linux-kernel
Cc: Sasha Levin
we've tested the wrong variable for allocation failure, fix it to
test the right one.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
tools/lib/traceevent/event-parse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 5a824e3..7538a1f 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -2481,7 +2481,7 @@ process_dynamic_array(struct event_format *event, struct print_arg *arg, char **
free_token(token);
arg = alloc_arg();
- if (!field) {
+ if (!arg) {
do_warning("%s: not enough memory!", __func__);
*tok = NULL;
return EVENT_ERROR;
--
1.8.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tools lib traceevent: test correct variable after allocation
2012-12-21 20:00 [PATCH] tools lib traceevent: test correct variable after allocation Sasha Levin
@ 2012-12-26 4:28 ` Namhyung Kim
2013-01-25 11:25 ` [tip:perf/core] " tip-bot for Sasha Levin
1 sibling, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2012-12-26 4:28 UTC (permalink / raw)
To: Sasha Levin
Cc: Steven Rostedt, Arnaldo Carvalho de Melo, Frederic Weisbecker,
linux-kernel
Hi Sasha,
On Fri, 21 Dec 2012 15:00:58 -0500, Sasha Levin wrote:
> we've tested the wrong variable for allocation failure, fix it to
> test the right one.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perf/core] tools lib traceevent: test correct variable after allocation
2012-12-21 20:00 [PATCH] tools lib traceevent: test correct variable after allocation Sasha Levin
2012-12-26 4:28 ` Namhyung Kim
@ 2013-01-25 11:25 ` tip-bot for Sasha Levin
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Sasha Levin @ 2013-01-25 11:25 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, linux-kernel, sasha.levin, hpa, mingo, namhyung, fweisbec,
rostedt, tglx
Commit-ID: fba7a78220fd969beeaa9abbb97c5f7027a7b4fd
Gitweb: http://git.kernel.org/tip/fba7a78220fd969beeaa9abbb97c5f7027a7b4fd
Author: Sasha Levin <sasha.levin@oracle.com>
AuthorDate: Fri, 21 Dec 2012 15:00:58 -0500
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 24 Jan 2013 16:40:16 -0300
tools lib traceevent: test correct variable after allocation
we've tested the wrong variable for allocation failure, fix it to
test the right one.
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1356120062-2648-1-git-send-email-sasha.levin@oracle.com
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/traceevent/event-parse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 5a824e3..7538a1f 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -2481,7 +2481,7 @@ process_dynamic_array(struct event_format *event, struct print_arg *arg, char **
free_token(token);
arg = alloc_arg();
- if (!field) {
+ if (!arg) {
do_warning("%s: not enough memory!", __func__);
*tok = NULL;
return EVENT_ERROR;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-25 11:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-21 20:00 [PATCH] tools lib traceevent: test correct variable after allocation Sasha Levin
2012-12-26 4:28 ` Namhyung Kim
2013-01-25 11:25 ` [tip:perf/core] " tip-bot for Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome