mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] ALSA: usb-audio: quirk_flags parsing fix and Logitech PRO X 2 LIGHTSPEED quirk
@ 2026-11-20 12:03 chris
  2026-11-20 12:03 ` [PATCH 1/2] ALSA: usb-audio: Ignore trailing whitespace in quirk_flags chris
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: chris @ 2026-11-20 12:03 UTC (permalink / raw)
  To: Takashi Iwai, Jaroslav Kysela
  Cc: Christopher Snowhill, Cryolitia PukNgae, Rong Zhang, linux-sound,
	linux-kernel

Patch 1 fixes parsing of flag names written to the quirk_flags module
parameter with a trailing newline, as echo produces.

Patch 2 adds quirk flags for the Logitech PRO X 2 LIGHTSPEED receiver
(046d:0af7). This is a mitigation, not a fix. After a hotplug the
receiver firmware resets itself on the first stream open, and also on
repeated GET_STATUS requests or on SET_CONFIGURATION shortly after a
port reset. It only behaves once it has gone through such a reset of
its own. The flags avoid the worse failure, where the probe-time
interface setup wedges the receiver for about 77 seconds.

The same receiver hotplugs without trouble on Windows and macOS. A
USBPcap capture of a Windows hotplug, with G HUB installed, shows no
missing request that made a difference when I tried it. Replaying
G HUB's initial HID reports before the audio driver binds did not
help, and neither did a host port reset. These differences were not
isolated:
- Windows never sends GET_STATUS.
- It sets the playback alt setting once, about 0.9 s after
  configuration, and keeps it.
- It only reads the volume controls at probe.
Suggestions on how to narrow this down, or on whether the quirk should
be expressed differently, are welcome. Captures and logs are available.

The device entry repeats CTL_MSG_DELAY_1M from the Logitech vendor
entry, as the other Logitech device entries do, because a device entry
replaces the vendor match. The receiver also worked with only
SKIP_IFACE_SETUP | IFACE_DELAY. The PRO X Wireless (046d:0aba) entry
does not carry the delay; Rong, I'm not sure whether that was intended.

Testing: with both patches applied, sound/usb/ builds without warnings
with W=1 and checkpatch --strict is clean. Patch 2 was runtime-tested on
a 7.3.5 stable kernel. Cold hotplugs on a front-panel (PROM21) port and
a rear (CPU xHCI, behind a hub) port recover within half a second and
then play normally.
Patch 1 was runtime-tested on the same kernel. Flag names written with
a plain echo are applied, and an empty echo is ignored by the parser.
The sysfs readback still shows the newline as written, because the
parameter stores the raw string. That is cosmetic and left unchanged.

Assisted-by: AI

Christopher Snowhill (2):
  ALSA: usb-audio: Ignore trailing whitespace in quirk_flags
  ALSA: usb-audio: Add quirk flags for Logitech PRO X 2 LIGHTSPEED

 sound/usb/quirks.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)


base-commit: 58161ead29e50d70a317ea26b472e0c7508e69da
-- 
2.56.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-20 17:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-20 12:03 [PATCH 0/2] ALSA: usb-audio: quirk_flags parsing fix and Logitech PRO X 2 LIGHTSPEED quirk chris
2026-11-20 12:03 ` [PATCH 1/2] ALSA: usb-audio: Ignore trailing whitespace in quirk_flags chris
2026-11-20 12:03 ` [PATCH 2/2] ALSA: usb-audio: Add quirk flags for Logitech PRO X 2 LIGHTSPEED chris
2026-11-20 17:09 ` [PATCH 0/2] ALSA: usb-audio: quirk_flags parsing fix and Logitech PRO X 2 LIGHTSPEED quirk Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®