* [PATCH] drm: dp: fix a possible memory leak in fetch_monitor_name()
@ 2022-05-16 3:20 Hangyu Hua
2022-05-17 19:52 ` Lyude Paul
0 siblings, 1 reply; 2+ messages in thread
From: Hangyu Hua @ 2022-05-16 3:20 UTC (permalink / raw)
To: airlied, daniel, lyude, tzimmermann, jani.nikula,
Bhawanpreet.Lakha, Wayne.Lin
Cc: dri-devel, linux-kernel, Hangyu Hua
drm_dp_mst_get_edid call kmemdup to create mst_edid. So mst_edid need to be
freed after use.
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
---
drivers/gpu/drm/dp/drm_dp_mst_topology.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/dp/drm_dp_mst_topology.c b/drivers/gpu/drm/dp/drm_dp_mst_topology.c
index 11300b53d24f..7a7cc44686f9 100644
--- a/drivers/gpu/drm/dp/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/dp/drm_dp_mst_topology.c
@@ -4852,6 +4852,7 @@ static void fetch_monitor_name(struct drm_dp_mst_topology_mgr *mgr,
mst_edid = drm_dp_mst_get_edid(port->connector, mgr, port);
drm_edid_get_monitor_name(mst_edid, name, namelen);
+ kfree(mst_edid);
}
/**
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: dp: fix a possible memory leak in fetch_monitor_name()
2022-05-16 3:20 [PATCH] drm: dp: fix a possible memory leak in fetch_monitor_name() Hangyu Hua
@ 2022-05-17 19:52 ` Lyude Paul
0 siblings, 0 replies; 2+ messages in thread
From: Lyude Paul @ 2022-05-17 19:52 UTC (permalink / raw)
To: Hangyu Hua, airlied, daniel, tzimmermann, jani.nikula,
Bhawanpreet.Lakha, Wayne.Lin
Cc: dri-devel, linux-kernel
Reviewed-by: Lyude Paul <lyude@redhat.com>
Will push to the appropriate branch in a bit
On Mon, 2022-05-16 at 11:20 +0800, Hangyu Hua wrote:
> drm_dp_mst_get_edid call kmemdup to create mst_edid. So mst_edid need to be
> freed after use.
>
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> ---
> drivers/gpu/drm/dp/drm_dp_mst_topology.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/dp/drm_dp_mst_topology.c
> b/drivers/gpu/drm/dp/drm_dp_mst_topology.c
> index 11300b53d24f..7a7cc44686f9 100644
> --- a/drivers/gpu/drm/dp/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/dp/drm_dp_mst_topology.c
> @@ -4852,6 +4852,7 @@ static void fetch_monitor_name(struct
> drm_dp_mst_topology_mgr *mgr,
>
> mst_edid = drm_dp_mst_get_edid(port->connector, mgr, port);
> drm_edid_get_monitor_name(mst_edid, name, namelen);
> + kfree(mst_edid);
> }
>
> /**
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-17 19:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 3:20 [PATCH] drm: dp: fix a possible memory leak in fetch_monitor_name() Hangyu Hua
2022-05-17 19:52 ` Lyude Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®