From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Chancel Liu <chancel.liu@oss.nxp.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ASoC: audio-graph-card: Free jack GPIOs on card remove
Date: Tue, 15 Sep 2026 03:16:16 +0000 [thread overview]
Message-ID: <877bknrypr.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <e682aeb8-9d52-4854-81f1-3b1ba38b48fb@oss.nxp.com>
Hi Chancel
> For this series I would like to keep the scope limited to the generic
> cards. If this approach can be accepted, we can extend this fix to other
> cards.
>
> tegra_audio_graph_card has a slightly more complicated card->probe. It
> also handles some clocks besides calling graph_util_card_probe(). So I
> think this driver leaks both the clocks and the jack resources on card
> unbind/rebind. I prefer a separate patch to fix tegra_audio_graph_card.
OK. I have no big objection about it.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2026-09-15 3:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 10:24 [PATCH 0/4] ASoC: generic: " Chancel Liu
2026-09-13 10:24 ` [PATCH 1/4] ASoC: simple-card-utils: Add simple_util_remove_jack() Chancel Liu
2026-09-13 10:25 ` [PATCH 2/4] ASoC: simple-card: Free jack GPIOs on card remove Chancel Liu
2026-09-13 10:25 ` [PATCH 3/4] ASoC: audio-graph-card: " Chancel Liu
2026-09-14 0:29 ` Kuninori Morimoto
2026-09-15 2:46 ` Chancel Liu
2026-09-15 3:16 ` Kuninori Morimoto [this message]
2026-09-13 10:25 ` [PATCH 4/4] ASoC: audio-graph-card2: " Chancel Liu
2026-09-15 16:36 ` [PATCH 0/4] ASoC: generic: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877bknrypr.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=broonie@kernel.org \
--cc=chancel.liu@oss.nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®