From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Chancel Liu <chancel.liu@oss.nxp.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ASoC: audio-graph-card: Free jack GPIOs on card remove
Date: Mon, 14 Sep 2026 00:29:14 +0000 [thread overview]
Message-ID: <87wlsollph.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20260913102502.2805912-4-chancel.liu@oss.nxp.com>
Hi Chancel
Thank you for the patch
> --- a/sound/soc/generic/audio-graph-card.c
> +++ b/sound/soc/generic/audio-graph-card.c
> @@ -629,6 +629,7 @@ static int graph_probe(struct platform_device *pdev)
> card->dapm_widgets = graph_dapm_widgets;
> card->num_dapm_widgets = ARRAY_SIZE(graph_dapm_widgets);
> card->probe = graph_util_card_probe;
> + card->remove = graph_util_card_remove;
Basically it looks good to me, but tegra_audio_graph_card is
using graph_util_card_probe(), too. Please care about this driver.
${LINUX}/sound/soc/tegra/tegra_audio_graph_card.c
Except above,
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2026-09-14 0:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 10:24 [PATCH 0/4] ASoC: generic: " Chancel Liu
2026-09-13 10:24 ` [PATCH 1/4] ASoC: simple-card-utils: Add simple_util_remove_jack() Chancel Liu
2026-09-13 10:25 ` [PATCH 2/4] ASoC: simple-card: Free jack GPIOs on card remove Chancel Liu
2026-09-13 10:25 ` [PATCH 3/4] ASoC: audio-graph-card: " Chancel Liu
2026-09-14 0:29 ` Kuninori Morimoto [this message]
2026-09-15 2:46 ` Chancel Liu
2026-09-15 3:16 ` Kuninori Morimoto
2026-09-13 10:25 ` [PATCH 4/4] ASoC: audio-graph-card2: " Chancel Liu
2026-09-15 16:36 ` [PATCH 0/4] ASoC: generic: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wlsollph.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=broonie@kernel.org \
--cc=chancel.liu@oss.nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®