From: Javier Martinez Canillas <javierm@redhat.com>
To: Amit Barzilai <amit.barzilai22@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Amit Barzilai <amit.barzilai22@gmail.com>
Subject: Re: [PATCH 2/2] drm/ssd130x: Add per-family update backlight logic
Date: Thu, 30 Jul 2026 10:07:11 +0200 [thread overview]
Message-ID: <877bmcew9c.fsf@ocarina.mail-host-address-is-not-set> (raw)
In-Reply-To: <20260729053054.29374-3-amit.barzilai22@gmail.com>
Amit Barzilai <amit.barzilai22@gmail.com> writes:
> ssd130x_update_bl() runs for every SSD13xx panel, but it only works for
> SSD130x and SSD132x: it writes the single global SSD13XX_CONTRAST (0x81)
> command, which those two families expose. SSD133x has no such command --
> it has three per-channel contrast registers (CONTRAST_A/B/C) that must be
> scaled together -- so ssd130x_update_bl() has no effect on it.
>
> Make backlight_ops.update_status a per-family choice. SSD130x and SSD132x
> keep ssd130x_update_bl() because they share the SSD13XX_CONTRAST interface,
> while SSD133x gets ssd133x_update_bl(), which drives the three channels
> through ssd133x_set_contrast().
>
> Signed-off-by: Amit Barzilai <amit.barzilai22@gmail.com>
> ---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2026-07-30 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 5:30 [PATCH 0/2] drm/ssd130x: Wire up ssd133x backlight/dimming Amit Barzilai
2026-07-29 5:30 ` [PATCH 1/2] drm/ssd130x: Scale ssd133x per-channel contrast by brightness on init Amit Barzilai
2026-07-30 8:01 ` Javier Martinez Canillas
2026-07-29 5:30 ` [PATCH 2/2] drm/ssd130x: Add per-family update backlight logic Amit Barzilai
2026-07-30 8:07 ` Javier Martinez Canillas [this message]
2026-07-31 7:20 ` [PATCH 0/2] drm/ssd130x: Wire up ssd133x backlight/dimming Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877bmcew9c.fsf@ocarina.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=airlied@gmail.com \
--cc=amit.barzilai22@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®