From: Michael Ellerman <mpe@ellerman.id.au>
To: Anju T Sudhakar <anju@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
maddy@linux.vnet.ibm.com, anju@linux.vnet.ibm.com
Subject: Re: [PATCH] powerpc/powernv: Fix IMC_MAX_PMU macro
Date: Fri, 10 Nov 2017 08:02:23 +1100 [thread overview]
Message-ID: <877euzp3mo.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1510229426-5547-1-git-send-email-anju@linux.vnet.ibm.com>
Anju T Sudhakar <anju@linux.vnet.ibm.com> writes:
> IMC_MAX_PMU is used for static storage (per_nest_pmu_arr) which holds
> nest pmu information. Current value for the macro is 32 based on
> the initial number of nest pmu units supported by the nest microcode.
> Currently 29 nest units are enabled based on the system configuration.
> But going forward, microcode could support more nest units (max of 64
> nest units). Hence fix the value for the macro.
There should be no reason to have a hard coded limit.
We should just fix the code to dynamically size the array based on
what's found in the device tree.
cheers
> Fixes:8f95faaac56c1 ('powerpc/powernv: Detect and create IMC device')
> Signed-off-by: Anju T Sudhakar <anju@linux.vnet.ibm.com>
> ---
> arch/powerpc/include/asm/imc-pmu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/imc-pmu.h b/arch/powerpc/include/asm/imc-pmu.h
> index 7f74c28..f9f0f2e 100644
> --- a/arch/powerpc/include/asm/imc-pmu.h
> +++ b/arch/powerpc/include/asm/imc-pmu.h
> @@ -23,7 +23,7 @@
> /*
> * For static allocation of some of the structures.
> */
> -#define IMC_MAX_PMUS 32
> +#define IMC_MAX_PMUS 64
>
> /*
> * Compatibility macros for IMC devices
> --
> 2.7.4
next prev parent reply other threads:[~2017-11-09 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 12:10 Anju T Sudhakar
2017-11-09 21:02 ` Michael Ellerman [this message]
2017-11-10 1:02 ` Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877euzp3mo.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=anju@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®