From: Johannes Weiner <hannes@saeurebad.de>
To: Philipp Marek <philipp@marek.priv.at>
Cc: linux-kernel@vger.kernel.org, linux-trivial@kernel.org
Subject: Re: [patch] kmalloc returns (void*), don't do type conversions
Date: Wed, 21 May 2008 22:17:34 +0200 [thread overview]
Message-ID: <877idn4dk1.fsf@saeurebad.de> (raw)
In-Reply-To: <200805212113.51936@marek.priv.at> (Philipp Marek's message of "Wed, 21 May 2008 21:13:51 +0200")
Hi Phillip,
Philipp Marek <philipp@marek.priv.at> writes:
> I tried a "make allyesconfig", but that gave some compile errors
> that don't seem related to my changes:
> drivers/block/cciss_scsi.c:75: error: ‘MAX_CTLR’ undeclared here (not in a function)
> drivers/block/cciss_scsi.c:76: error: field name not in record or union initializer
You probably should write another email regarding this.
> Please tell me if that's the correct approach; I'm sorry that I
> couldn't find out who the correct maintainer for these changes is.
Added the trivial tree maintainer to CC. Jesper?
> $ diffstat kmalloc-type-changes.patch
> arch/cris/arch-v32/mm/intmem.c | 13 +++++--------
> arch/ia64/kernel/mca_drv.c | 4 ++--
> arch/powerpc/kernel/nvram_64.c | 3 +--
> drivers/block/cciss.c | 3 +--
> drivers/block/cciss_scsi.c | 3 +--
> drivers/block/floppy.c | 3 +--
> drivers/i2c/i2c-dev.c | 3 +--
> drivers/isdn/capi/capidrv.c | 3 +--
> drivers/isdn/hisax/hfc_sx.c | 5 +++--
> drivers/media/video/vino.c | 8 ++++----
> drivers/message/i2o/i2o_config.c | 3 +--
> drivers/mtd/maps/tqm8xxl.c | 2 +-
> drivers/net/gianfar.c | 6 ++----
> drivers/net/s2io.c | 4 ++--
> drivers/net/tulip/eeprom.c | 8 ++++----
> drivers/net/wireless/hostap/hostap_80211_rx.c | 3 +--
> drivers/net/wireless/hostap/hostap_ioctl.c | 3 +--
> drivers/net/wireless/ipw2100.c | 10 ++++------
> drivers/net/wireless/zd1211rw/zd_chip.c | 2 +-
> drivers/s390/net/ctcm_mpc.c | 6 ++----
> drivers/s390/net/qeth_core_main.c | 4 ++--
> drivers/scsi/osst.c | 5 ++---
> drivers/usb/storage/isd200.c | 3 +--
> fs/befs/btree.c | 4 ++--
> fs/ufs/util.c | 3 +--
> net/ipv4/igmp.c | 3 +--
> net/ipv6/mcast.c | 3 +--
> net/sctp/protocol.c | 4 ++--
> security/selinux/ss/conditional.c | 4 ++--
> 29 files changed, 53 insertions(+), 75 deletions(-)
You can include the diffstat in the patch as comment. And please don't
attach patches, include them inline. See
Documentation/SubmittingPatches.
> Remove type conversions that are done on the result of kmalloc() -
> this is defined as (void*).
How about:
Remove unneeded explicit casting from kmalloc() return values.
> Signed-off-by: philipp@marek.priv.at
Better use: Real Name <user@domain>
Hope that helps,
Hannes
next prev parent reply other threads:[~2008-05-21 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 19:13 Philipp Marek
2008-05-21 20:17 ` Johannes Weiner [this message]
2008-05-21 22:15 ` Johannes Weiner
2008-05-21 22:24 ` Jesper Juhl
2008-05-22 9:09 ` [patch v2] " Philipp Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877idn4dk1.fsf@saeurebad.de \
--to=hannes@saeurebad.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trivial@kernel.org \
--cc=philipp@marek.priv.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®