From: "Jesper Juhl" <jesper.juhl@gmail.com>
To: "Johannes Weiner" <hannes@saeurebad.de>
Cc: "Philipp Marek" <philipp@marek.priv.at>,
linux-kernel@vger.kernel.org, linux-trivial@kernel.org
Subject: Re: [patch] kmalloc returns (void*), don't do type conversions
Date: Thu, 22 May 2008 00:24:03 +0200 [thread overview]
Message-ID: <9a8748490805211524r10bac2c8ke6e3766c0b5152f1@mail.gmail.com> (raw)
In-Reply-To: <877idn4dk1.fsf@saeurebad.de>
2008/5/21 Johannes Weiner <hannes@saeurebad.de>:
> Hi Phillip,
>
> Philipp Marek <philipp@marek.priv.at> writes:
>
>> I tried a "make allyesconfig", but that gave some compile errors
>> that don't seem related to my changes:
>> drivers/block/cciss_scsi.c:75: error: 'MAX_CTLR' undeclared here (not in a function)
>> drivers/block/cciss_scsi.c:76: error: field name not in record or union initializer
>
> You probably should write another email regarding this.
>
I agree, keep things seperate. One mail with patch to fix casts,
another to report build breakage.
>> Please tell me if that's the correct approach; I'm sorry that I
>> couldn't find out who the correct maintainer for these changes is.
>
> Added the trivial tree maintainer to CC. Jesper?
>
Thank you, I'll keep an eye on this patch.
Philipp: Johannes makes some good points, please address his comments
and re-submit the patch with trivial@kernel.org on Cc: if it draws no
negative comments it looks good to me to add to the trivial tree.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
next prev parent reply other threads:[~2008-05-21 22:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 19:13 Philipp Marek
2008-05-21 20:17 ` Johannes Weiner
2008-05-21 22:15 ` Johannes Weiner
2008-05-21 22:24 ` Jesper Juhl [this message]
2008-05-22 9:09 ` [patch v2] " Philipp Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490805211524r10bac2c8ke6e3766c0b5152f1@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=hannes@saeurebad.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trivial@kernel.org \
--cc=philipp@marek.priv.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®