* [PATCH] ALSA: pcmtest: Honor the enable parameter
@ 2026-10-27 1:22 HyeongJun An
2026-10-27 6:38 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: HyeongJun An @ 2026-10-27 1:22 UTC (permalink / raw)
To: tiwai; +Cc: ivan.orlov0322, perex, linux-sound, linux-kernel, HyeongJun An
The enable module parameter is declared and documented as "Enable
pcmtest soundcard.", but nothing reads it. Loading the module with
enable=0 still creates the card.
Return -ENODEV from mod_init() when enable is false, as the pcsp driver
does.
Fixes: 315a3d57c64c ("ALSA: Implement the new Virtual PCM Test Driver")
Signed-off-by: HyeongJun An <sammiee5311@gmail.com>
---
Prepared with Claude Code (Claude Opus 5.5). Tested on x86_64: enable=0
now fails with -ENODEV and creates no card, and the pcmtest selftest
still passes.
sound/drivers/pcmtest.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/drivers/pcmtest.c b/sound/drivers/pcmtest.c
index 422fdb10f237..66bee8a2ce34 100644
--- a/sound/drivers/pcmtest.c
+++ b/sound/drivers/pcmtest.c
@@ -712,6 +712,9 @@ static int __init mod_init(void)
{
int err = 0;
+ if (!enable)
+ return -ENODEV;
+
buf_allocated = setup_patt_bufs();
if (!buf_allocated)
return -ENOMEM;
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: pcmtest: Honor the enable parameter
2026-10-27 1:22 [PATCH] ALSA: pcmtest: Honor the enable parameter HyeongJun An
@ 2026-10-27 6:38 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-10-27 6:38 UTC (permalink / raw)
To: HyeongJun An; +Cc: tiwai, ivan.orlov0322, perex, linux-sound, linux-kernel
On Tue, 27 Oct 2026 02:22:27 +0100,
HyeongJun An wrote:
>
> The enable module parameter is declared and documented as "Enable
> pcmtest soundcard.", but nothing reads it. Loading the module with
> enable=0 still creates the card.
>
> Return -ENODEV from mod_init() when enable is false, as the pcsp driver
> does.
>
> Fixes: 315a3d57c64c ("ALSA: Implement the new Virtual PCM Test Driver")
> Signed-off-by: HyeongJun An <sammiee5311@gmail.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-27 6:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-27 1:22 [PATCH] ALSA: pcmtest: Honor the enable parameter HyeongJun An
2026-10-27 6:38 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®