mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Bartosz Brom <bartosz.brom06@gmail.com>
Cc: tiwai@suse.de, perex@perex.cz, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: hda/realtek: Add mute LED quirk for HP Pavilion 15-eh3174nw
Date: Mon, 28 Sep 2026 14:41:39 +0200	[thread overview]
Message-ID: <878q4l5z0c.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAN3WbsTf=MYcGC7mCYtAvtgcwXpUQDSG6VRpmVZ-s-erCaP19A@mail.gmail.com>

On Sat, 19 Sep 2026 13:32:28 +0200,
Bartosz Brom wrote:
> 
> The HP Pavilion 15-eh3174nw with an ALC287 codec requires the
> ALC287_FIXUP_HP_GPIO_LED fixup for its mute LED to work correctly.
> 
> Add subsystem ID 0x103c:0x8bc7 to the quirk table to apply the
> existing fixup.
> 
> Tested on an HP Pavilion 15-eh3174nw; the mute LED now follows the
> speaker mute state.
> 
> Signed-off-by: Bartosz Brom <bartosz.brom06@gmail.com>
> ---
> diff --git a/sound/hda/codecs/realtek/alc269.c
> b/sound/hda/codecs/realtek/alc269.c
> index 5127a111c..2956e666e 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -7581,6 +7581,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>         SND_PCI_QUIRK(0x103c, 0x8bb4, "HP Slim OMEN",
> ALC287_FIXUP_CS35L41_I2C_2),
>         SND_PCI_QUIRK(0x103c, 0x8bb6, "HP Laptop 15-fd0039nt",
> ALC236_FIXUP_HP_15_FD0XXX),
>         SND_PCI_QUIRK(0x103c, 0x8bbe, "HP Victus 16-r0xxx (MB 8BBE)",
> ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
> +       SND_PCI_QUIRK(0x103c, 0x8bc7, "HP Pavilion 15-eh3174nw",
> ALC287_FIXUP_HP_GPIO_LED),
>         SND_PCI_QUIRK(0x103c, 0x8bc8, "HP Victus 15-fa1xxx",
> ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
>         SND_PCI_QUIRK(0x103c, 0x8bcd, "HP Omen 16-xd0xxx",
> ALC245_FIXUP_HP_MUTE_LED_V1_COEFBIT),
>         SND_PCI_QUIRK(0x103c, 0x8bd4, "HP Victus 16-s0xxx (MB 8BD4)",
> ALC245_FIXUP_HP_MUTE_LED_COEFBIT),

Unfortunately the patch isn't applicable because your mailer broke the
spaces and the tabs.

Please correct your mailer setup and resubmit (at best with git
send-email).  If you are unsure, it'd be better to try once to send to
yourself and verify that you can apply the patch via git-am correctly
before actually submitting to the upstream.


thanks,

Takashi

      reply	other threads:[~2026-09-28 12:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-19 11:32 Bartosz Brom
2026-09-28 12:41 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878q4l5z0c.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=bartosz.brom06@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®