mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] ALSA: hda/realtek: Add mute LED quirk for HP Pavilion 15-eh3174nw
@ 2026-09-19 11:32 Bartosz Brom
  2026-09-28 12:41 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Brom @ 2026-09-19 11:32 UTC (permalink / raw)
  To: tiwai, perex; +Cc: linux-sound, linux-kernel

The HP Pavilion 15-eh3174nw with an ALC287 codec requires the
ALC287_FIXUP_HP_GPIO_LED fixup for its mute LED to work correctly.

Add subsystem ID 0x103c:0x8bc7 to the quirk table to apply the
existing fixup.

Tested on an HP Pavilion 15-eh3174nw; the mute LED now follows the
speaker mute state.

Signed-off-by: Bartosz Brom <bartosz.brom06@gmail.com>
---
diff --git a/sound/hda/codecs/realtek/alc269.c
b/sound/hda/codecs/realtek/alc269.c
index 5127a111c..2956e666e 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7581,6 +7581,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
        SND_PCI_QUIRK(0x103c, 0x8bb4, "HP Slim OMEN",
ALC287_FIXUP_CS35L41_I2C_2),
        SND_PCI_QUIRK(0x103c, 0x8bb6, "HP Laptop 15-fd0039nt",
ALC236_FIXUP_HP_15_FD0XXX),
        SND_PCI_QUIRK(0x103c, 0x8bbe, "HP Victus 16-r0xxx (MB 8BBE)",
ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
+       SND_PCI_QUIRK(0x103c, 0x8bc7, "HP Pavilion 15-eh3174nw",
ALC287_FIXUP_HP_GPIO_LED),
        SND_PCI_QUIRK(0x103c, 0x8bc8, "HP Victus 15-fa1xxx",
ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
        SND_PCI_QUIRK(0x103c, 0x8bcd, "HP Omen 16-xd0xxx",
ALC245_FIXUP_HP_MUTE_LED_V1_COEFBIT),
        SND_PCI_QUIRK(0x103c, 0x8bd4, "HP Victus 16-s0xxx (MB 8BD4)",
ALC245_FIXUP_HP_MUTE_LED_COEFBIT),

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] ALSA: hda/realtek: Add mute LED quirk for HP Pavilion 15-eh3174nw
  2026-09-19 11:32 [PATCH v2] ALSA: hda/realtek: Add mute LED quirk for HP Pavilion 15-eh3174nw Bartosz Brom
@ 2026-09-28 12:41 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-09-28 12:41 UTC (permalink / raw)
  To: Bartosz Brom; +Cc: tiwai, perex, linux-sound, linux-kernel

On Sat, 19 Sep 2026 13:32:28 +0200,
Bartosz Brom wrote:
> 
> The HP Pavilion 15-eh3174nw with an ALC287 codec requires the
> ALC287_FIXUP_HP_GPIO_LED fixup for its mute LED to work correctly.
> 
> Add subsystem ID 0x103c:0x8bc7 to the quirk table to apply the
> existing fixup.
> 
> Tested on an HP Pavilion 15-eh3174nw; the mute LED now follows the
> speaker mute state.
> 
> Signed-off-by: Bartosz Brom <bartosz.brom06@gmail.com>
> ---
> diff --git a/sound/hda/codecs/realtek/alc269.c
> b/sound/hda/codecs/realtek/alc269.c
> index 5127a111c..2956e666e 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -7581,6 +7581,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>         SND_PCI_QUIRK(0x103c, 0x8bb4, "HP Slim OMEN",
> ALC287_FIXUP_CS35L41_I2C_2),
>         SND_PCI_QUIRK(0x103c, 0x8bb6, "HP Laptop 15-fd0039nt",
> ALC236_FIXUP_HP_15_FD0XXX),
>         SND_PCI_QUIRK(0x103c, 0x8bbe, "HP Victus 16-r0xxx (MB 8BBE)",
> ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
> +       SND_PCI_QUIRK(0x103c, 0x8bc7, "HP Pavilion 15-eh3174nw",
> ALC287_FIXUP_HP_GPIO_LED),
>         SND_PCI_QUIRK(0x103c, 0x8bc8, "HP Victus 15-fa1xxx",
> ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
>         SND_PCI_QUIRK(0x103c, 0x8bcd, "HP Omen 16-xd0xxx",
> ALC245_FIXUP_HP_MUTE_LED_V1_COEFBIT),
>         SND_PCI_QUIRK(0x103c, 0x8bd4, "HP Victus 16-s0xxx (MB 8BD4)",
> ALC245_FIXUP_HP_MUTE_LED_COEFBIT),

Unfortunately the patch isn't applicable because your mailer broke the
spaces and the tabs.

Please correct your mailer setup and resubmit (at best with git
send-email).  If you are unsure, it'd be better to try once to send to
yourself and verify that you can apply the patch via git-am correctly
before actually submitting to the upstream.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-28 12:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-19 11:32 [PATCH v2] ALSA: hda/realtek: Add mute LED quirk for HP Pavilion 15-eh3174nw Bartosz Brom
2026-09-28 12:41 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®