From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@ti.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] usb: musb: convert printk to pr_*
Date: Mon, 30 Nov 2015 21:48:32 +0100 [thread overview]
Message-ID: <878u5fb4db.fsf@rasmusvillemoes.dk> (raw)
In-Reply-To: <5659803B.60807@cogentembedded.com> (Sergei Shtylyov's message of "Sat, 28 Nov 2015 13:21:47 +0300")
On Sat, Nov 28 2015, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
> On 11/28/2015 3:04 AM, Greg Kroah-Hartman wrote:
>
>>>> This file already uses pr_debug in a few places; this converts the
>>>> remaining printks.
>>>
>>> Are you aware that printk(KERN_DEBUG, ...) and pr_debug() are not equivalent?
>>
>> Yes, and that is a good thing, you should be using pr_debug() instead of
>> printk(KERN_DEBUG...).
>>
>> Why object to something like this?
>
> I'm not objecting, just asking. There have been many cases in my
> practice where a patch author wasn't aware of that...
I was aware, but I can see how the commit message could indicate
otherwise. I don't feel strongly for the conversion, so I could redo 2/3
and 3/3 (which should be uncontroversial cleanups).
Rasmus
prev parent reply other threads:[~2015-11-30 20:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 10:38 Rasmus Villemoes
2015-11-27 10:38 ` [PATCH 2/3] usb: musb: remove always-empty string from debug output Rasmus Villemoes
2015-11-27 10:38 ` [PATCH 3/3] usb: musb: remove redundant stack buffer Rasmus Villemoes
2015-12-01 15:00 ` Felipe Balbi
2015-12-03 9:31 ` Rasmus Villemoes
2015-11-27 12:23 ` [PATCH 1/3] usb: musb: convert printk to pr_* Sergei Shtylyov
2015-11-28 0:04 ` Greg Kroah-Hartman
2015-11-28 10:21 ` Sergei Shtylyov
2015-11-30 20:48 ` Rasmus Villemoes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u5fb4db.fsf@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome