From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Felipe Balbi <balbi@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] usb: musb: remove redundant stack buffer
Date: Thu, 03 Dec 2015 10:31:26 +0100 [thread overview]
Message-ID: <87vb8fq3o1.fsf@rasmusvillemoes.dk> (raw)
In-Reply-To: <874mg21ae7.fsf@saruman.tx.rr.com> (Felipe Balbi's message of "Tue, 1 Dec 2015 09:00:48 -0600")
On Tue, Dec 01 2015, Felipe Balbi <balbi@ti.com> wrote:
> Hi,
>
> Rasmus Villemoes <linux@rasmusvillemoes.dk> writes:
>> aRevision is only used once, so we might as well do the formatting as
>> part of the pr_debug. This eliminates the stack buffer, and avoids
>> doing the formatting at all when pr_debug is compiled out.
>>
>> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>
> this needs to be rebased on top of my testing/next:
git url, please.
> checking file drivers/usb/musb/musb_core.c
> Hunk #1 FAILED at 1458.
> Hunk #2 FAILED at 1506.
> 2 out of 2 hunks FAILED
Did 1/3 and 2/3 apply? They touch some of the same lines, so clearly 3/3
wouldn't apply by itself.
Rasmus
next prev parent reply other threads:[~2015-12-03 9:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 10:38 [PATCH 1/3] usb: musb: convert printk to pr_* Rasmus Villemoes
2015-11-27 10:38 ` [PATCH 2/3] usb: musb: remove always-empty string from debug output Rasmus Villemoes
2015-11-27 10:38 ` [PATCH 3/3] usb: musb: remove redundant stack buffer Rasmus Villemoes
2015-12-01 15:00 ` Felipe Balbi
2015-12-03 9:31 ` Rasmus Villemoes [this message]
2015-11-27 12:23 ` [PATCH 1/3] usb: musb: convert printk to pr_* Sergei Shtylyov
2015-11-28 0:04 ` Greg Kroah-Hartman
2015-11-28 10:21 ` Sergei Shtylyov
2015-11-30 20:48 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb8fq3o1.fsf@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome