mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lars Melin <larsm17@gmail.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Oliver Neukum <oneukum@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] usb: csc-acm: add Infineon/Comneon modem support (1519:0020)
Date: Tue, 27 Jan 2026 08:12:15 +0700	[thread overview]
Message-ID: <8794178c-0522-4532-b21e-3904f90619f6@gmail.com> (raw)
In-Reply-To: <CAPVz0n1x9gWC0XzC0VQ=syT3LAm_5xof-_T5=8TzKapBQheVjw@mail.gmail.com>

On 2026-01-26 21:55, Svyatoslav Ryhel wrote:
/snip
> 
> Bus 001 Device 002: ID 1519:0020 Comneon HSIC Device
> Couldn't open device, some information will be missing
> Negotiated speed: High Speed (480Mbps)
> Device Descriptor:
>    bLength                18
>    bDescriptorType         1
>    bcdUSB               2.00
>    bDeviceClass            2 [unknown]
>    bDeviceSubClass         0 [unknown]
>    bDeviceProtocol         0
>    bMaxPacketSize0        64
>    idVendor           0x1519 Comneon
>    idProduct          0x0020 HSIC Device
>    bcdDevice           12.74
>    iManufacturer           1 Comneon
>    iProduct                2 HSIC Device
>    iSerial                 3 0123456789
>    bNumConfigurations      1
>    Configuration Descriptor:
>      bLength                 9
>      bDescriptorType         2
>      wTotalLength       0x0111
>      bNumInterfaces          8
>      bConfigurationValue     1
>      iConfiguration          0
>      bmAttributes         0xc0
>        Self Powered
>      MaxPower              100mA
>      Interface Association:
>        bLength                 8
>        bDescriptorType        11
>        bFirstInterface         0
>        bInterfaceCount         2
>        bFunctionClass          2 [unknown]
>        bFunctionSubClass       2 [unknown]
>        bFunctionProtocol       1
>        iFunction               0
>      Interface Descriptor:
>        bLength                 9
>        bDescriptorType         4
>        bInterfaceNumber        0
>        bAlternateSetting       0
>        bNumEndpoints           1
>        bInterfaceClass         2 [unknown]
>        bInterfaceSubClass      2 [unknown]
>        bInterfaceProtocol      1
>        iInterface              4
>        CDC Header:
>          bcdCDC               1.10
>        CDC Union:
>          bMasterInterface        0
>          bSlaveInterface         1
>        CDC Call Management:
>          bmCapabilities       0x00
>          bDataInterface          1
>        CDC ACM:
>          bmCapabilities       0x07
>            sends break
>            line coding and serial state
>            get/set/clear comm features
>        Endpoint Descriptor:
>          bLength                 7
>          bDescriptorType         5
>          bEndpointAddress     0x85  EP 5 IN
>          bmAttributes            3
>            Transfer Type            Interrupt
>            Synch Type               None
>            Usage Type               Data
>          wMaxPacketSize     0x0040  1x 64 bytes
>          bInterval               4
>      Interface Descriptor:
>        bLength                 9
>        bDescriptorType         4
>        bInterfaceNumber        1
>        bAlternateSetting       0
>        bNumEndpoints           2
>        bInterfaceClass        10 [unknown]
>        bInterfaceSubClass      0 [unknown]
>        bInterfaceProtocol      0
>        iInterface              5
>        Endpoint Descriptor:
>          bLength                 7
>          bDescriptorType         5
>          bEndpointAddress     0x81  EP 1 IN
>          bmAttributes            2
>            Transfer Type            Bulk
>            Synch Type               None
>            Usage Type               Data
>          wMaxPacketSize     0x0200  1x 512 bytes
>          bInterval               0
>        Endpoint Descriptor:
>          bLength                 7
>          bDescriptorType         5
>          bEndpointAddress     0x01  EP 1 OUT
>          bmAttributes            2
>            Transfer Type            Bulk
>            Synch Type               None
>            Usage Type               Data
>          wMaxPacketSize     0x0200  1x 512 bytes
>          bInterval               0
>      Interface Association:
>        bLength                 8
>        bDescriptorType        11
>        bFirstInterface         2
>        bInterfaceCount         2
>        bFunctionClass          2 [unknown]
>        bFunctionSubClass       2 [unknown]
>        bFunctionProtocol       1
>        iFunction               0
>      Interface Descriptor:
>        bLength                 9
>        bDescriptorType         4
>        bInterfaceNumber        2
>        bAlternateSetting       0
>        bNumEndpoints           1
>        bInterfaceClass         2 [unknown]
>        bInterfaceSubClass      2 [unknown]
>        bInterfaceProtocol      1
>        iInterface              6
>        CDC Header:
>          bcdCDC               1.10
>        CDC Union:
>          bMasterInterface        2
>          bSlaveInterface         3
>        CDC Call Management:
>          bmCapabilities       0x00
>          bDataInterface          3
>        CDC ACM:
>          bmCapabilities       0x07
>            sends break
>            line coding and serial state
>            get/set/clear comm features
>        Endpoint Descriptor:
>          bLength                 7
>          bDescriptorType         5
>          bEndpointAddress     0x86  EP 6 IN
>          bmAttributes            3
>            Transfer Type            Interrupt
>            Synch Type               None
>            Usage Type               Data
>          wMaxPacketSize     0x0040  1x 64 bytes
>          bInterval               4
>      Interface Descriptor:
>        bLength                 9
>        bDescriptorType         4
>        bInterfaceNumber        3
>        bAlternateSetting       0
>        bNumEndpoints           2
>        bInterfaceClass        10 [unknown]
>        bInterfaceSubClass      0 [unknown]
>        bInterfaceProtocol      0
>        iInterface              7
>        Endpoint Descriptor:
>          bLength                 7
>          bDescriptorType         5
>          bEndpointAddress     0x82  EP 2 IN
>          bmAttributes            2
>            Transfer Type            Bulk
>            Synch Type               None
>            Usage Type               Data
>          wMaxPacketSize     0x0200  1x 512 bytes
>          bInterval               0
>        Endpoint Descriptor:
>          bLength                 7
>          bDescriptorType         5
>          bEndpointAddress     0x02  EP 2 OUT
>          bmAttributes            2
>            Transfer Type            Bulk
>            Synch Type               None
>            Usage Type               Data
>          wMaxPacketSize     0x0200  1x 512 bytes
>          bInterval               0
>      Interface Association:
>        bLength                 8
>        bDescriptorType        11
>        bFirstInterface         4
>        bInterfaceCount         2
>        bFunctionClass          2 [unknown]
>        bFunctionSubClass       2 [unknown]
>        bFunctionProtocol       1
>        iFunction               0
>      Interface Descriptor:
>        bLength                 9
>        bDescriptorType         4
>        bInterfaceNumber        4
>        bAlternateSetting       0
>        bNumEndpoints           1
>        bInterfaceClass         2 [unknown]
>        bInterfaceSubClass      2 [unknown]
>        bInterfaceProtocol      1
>        iInterface              8
>        CDC Header:
>          bcdCDC               1.10
>        CDC Union:
>          bMasterInterface        4
>          bSlaveInterface         5
>        CDC Call Management:
>          bmCapabilities       0x00
>          bDataInterface          5
>        CDC ACM:
>          bmCapabilities       0x07
>            sends break
>            line coding and serial state
>            get/set/clear comm features
>        Endpoint Descriptor:
>          bLength                 7
>          bDescriptorType         5
>          bEndpointAddress     0x87  EP 7 IN
>          bmAttributes            3
>            Transfer Type            Interrupt
>            Synch Type               None
>            Usage Type               Data
>          wMaxPacketSize     0x0040  1x 64 bytes
>          bInterval               4
>      Interface Descriptor:
>        bLength                 9
>        bDescriptorType         4
>        bInterfaceNumber        5
>        bAlternateSetting       0
>        bNumEndpoints           2
>        bInterfaceClass        10 [unknown]
>        bInterfaceSubClass      0 [unknown]
>        bInterfaceProtocol      0
>        iInterface              9
>        Endpoint Descriptor:
>          bLength                 7
>          bDescriptorType         5
>          bEndpointAddress     0x83  EP 3 IN
>          bmAttributes            2
>            Transfer Type            Bulk
>            Synch Type               None
>            Usage Type               Data
>          wMaxPacketSize     0x0200  1x 512 bytes
>          bInterval               0
>        Endpoint Descriptor:
>          bLength                 7
>          bDescriptorType         5
>          bEndpointAddress     0x03  EP 3 OUT
>          bmAttributes            2
>            Transfer Type            Bulk
>            Synch Type               None
>            Usage Type               Data
>          wMaxPacketSize     0x0200  1x 512 bytes
>          bInterval               0
>      Interface Association:
>        bLength                 8
>        bDescriptorType        11
>        bFirstInterface         6
>        bInterfaceCount         2
>        bFunctionClass          2 [unknown]
>        bFunctionSubClass       2 [unknown]
>        bFunctionProtocol       1
>        iFunction               0
>      Interface Descriptor:
>        bLength                 9
>        bDescriptorType         4
>        bInterfaceNumber        6
>        bAlternateSetting       0
>        bNumEndpoints           1
>        bInterfaceClass         2 [unknown]
>        bInterfaceSubClass      2 [unknown]
>        bInterfaceProtocol      1
>        iInterface             10
>        CDC Header:
>          bcdCDC               1.10
>        CDC Union:
>          bMasterInterface        6
>          bSlaveInterface         7
>        CDC Call Management:
>          bmCapabilities       0x00
>          bDataInterface          7
>        CDC ACM:
>          bmCapabilities       0x07
>            sends break
>            line coding and serial state
>            get/set/clear comm features
>        Endpoint Descriptor:
>          bLength                 7
>          bDescriptorType         5
>          bEndpointAddress     0x88  EP 8 IN
>          bmAttributes            3
>            Transfer Type            Interrupt
>            Synch Type               None
>            Usage Type               Data
>          wMaxPacketSize     0x0040  1x 64 bytes
>          bInterval               4
>      Interface Descriptor:
>        bLength                 9
>        bDescriptorType         4
>        bInterfaceNumber        7
>        bAlternateSetting       0
>        bNumEndpoints           2
>        bInterfaceClass        10 [unknown]
>        bInterfaceSubClass      0 [unknown]
>        bInterfaceProtocol      0
>        iInterface             11
>        Endpoint Descriptor:
>          bLength                 7
>          bDescriptorType         5
>          bEndpointAddress     0x84  EP 4 IN
>          bmAttributes            2
>            Transfer Type            Bulk
>            Synch Type               None
>            Usage Type               Data
>          wMaxPacketSize     0x0200  1x 512 bytes
>          bInterval               0
>        Endpoint Descriptor:
>          bLength                 7
>          bDescriptorType         5
>          bEndpointAddress     0x04  EP 4 OUT
>          bmAttributes            2
>            Transfer Type            Bulk
>            Synch Type               None
>            Usage Type               Data
>          wMaxPacketSize     0x0200  1x 512 bytes
>          bInterval               0
> 
Hi,

I can't see anything wrong with the union descriptor in your listing. 
What is your reason for adding this device to cdc-acm?

thanks
Lars

  reply	other threads:[~2026-01-27  1:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22 15:17 [PATCH v1 0/1] usb: csc-acm: add Infineon/Comneon modem support Svyatoslav Ryhel
2026-01-22 15:17 ` [PATCH v1 1/1] usb: csc-acm: add Infineon/Comneon modem support (1519:0020) Svyatoslav Ryhel
2026-01-22 15:58   ` Lars Melin
2026-01-22 16:17     ` Svyatoslav Ryhel
2026-01-26 13:51       ` Lars Melin
2026-01-26 14:55         ` Svyatoslav Ryhel
2026-01-27  1:12           ` Lars Melin [this message]
2026-01-27  6:50             ` Svyatoslav Ryhel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8794178c-0522-4532-b21e-3904f90619f6@gmail.com \
    --to=larsm17@gmail.com \
    --cc=clamor95@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®