* [PATCH] irqchip/riscv-imsic: Report successful hardware retrigger
@ 2026-10-26 12:26 Avi Weiss
2026-10-27 9:53 ` Björn Töpel
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Avi Weiss @ 2026-10-26 12:26 UTC (permalink / raw)
To: Anup Patel, Thomas Gleixner
Cc: Radu Rendec, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Alexandre Ghiti, Bjorn Topel, linux-riscv, linux-kernel,
Avi Weiss
imsic_irq_retrigger() writes to the IMSIC MSI register to retrigger
an interrupt, but returns 0. The IRQ core treats zero as failure and
may schedule a software resend despite the hardware retrigger.
Return 1 after the MSI write to report successful hardware
retriggering and prevent the unnecessary software resend.
Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
---
drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
index 95ff76e63a69..5f72b2a80887 100644
--- a/drivers/irqchip/irq-riscv-imsic-platform.c
+++ b/drivers/irqchip/irq-riscv-imsic-platform.c
@@ -61,7 +61,7 @@ static int imsic_irq_retrigger(struct irq_data *d)
local = per_cpu_ptr(imsic->global.local, vec->cpu);
writel_relaxed(vec->local_id, local->msi_va);
- return 0;
+ return 1;
}
static void imsic_irq_ack(struct irq_data *d)
base-commit: 6b4b543fa18757297ac756a6fe6e64f506b7844a
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] irqchip/riscv-imsic: Report successful hardware retrigger
2026-10-26 12:26 [PATCH] irqchip/riscv-imsic: Report successful hardware retrigger Avi Weiss
@ 2026-10-27 9:53 ` Björn Töpel
2026-10-27 11:43 ` Anup Patel
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Björn Töpel @ 2026-10-27 9:53 UTC (permalink / raw)
To: Avi Weiss, Anup Patel, Thomas Gleixner
Cc: Radu Rendec, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Alexandre Ghiti, Bjorn Topel, linux-riscv, linux-kernel,
Avi Weiss
Avi Weiss <thnkslprpt@gmail.com> writes:
> imsic_irq_retrigger() writes to the IMSIC MSI register to retrigger
> an interrupt, but returns 0. The IRQ core treats zero as failure and
> may schedule a software resend despite the hardware retrigger.
>
> Return 1 after the MSI write to report successful hardware
> retriggering and prevent the unnecessary software resend.
>
> Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
> Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
Nice catch!
Reviewed-by: Björn Töpel <bjorn@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] irqchip/riscv-imsic: Report successful hardware retrigger
2026-10-26 12:26 [PATCH] irqchip/riscv-imsic: Report successful hardware retrigger Avi Weiss
2026-10-27 9:53 ` Björn Töpel
@ 2026-10-27 11:43 ` Anup Patel
2026-10-28 20:29 ` [tip: irq/urgent] " tip-bot2 for Avi Weiss
2026-10-28 20:34 ` tip-bot2 for Avi Weiss
3 siblings, 0 replies; 5+ messages in thread
From: Anup Patel @ 2026-10-27 11:43 UTC (permalink / raw)
To: Avi Weiss
Cc: Thomas Gleixner, Radu Rendec, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Alexandre Ghiti, Bjorn Topel, linux-riscv,
linux-kernel
On Mon, Oct 26, 2026 at 5:56 PM Avi Weiss <thnkslprpt@gmail.com> wrote:
>
> imsic_irq_retrigger() writes to the IMSIC MSI register to retrigger
> an interrupt, but returns 0. The IRQ core treats zero as failure and
> may schedule a software resend despite the hardware retrigger.
>
> Return 1 after the MSI write to report successful hardware
> retriggering and prevent the unnecessary software resend.
>
> Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
> Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
Thanks for catching.
Reviewed-by: Anup Patel <anup@brainfault.org>
Regards,
Anup
> ---
> drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
> index 95ff76e63a69..5f72b2a80887 100644
> --- a/drivers/irqchip/irq-riscv-imsic-platform.c
> +++ b/drivers/irqchip/irq-riscv-imsic-platform.c
> @@ -61,7 +61,7 @@ static int imsic_irq_retrigger(struct irq_data *d)
>
> local = per_cpu_ptr(imsic->global.local, vec->cpu);
> writel_relaxed(vec->local_id, local->msi_va);
> - return 0;
> + return 1;
> }
>
> static void imsic_irq_ack(struct irq_data *d)
>
> base-commit: 6b4b543fa18757297ac756a6fe6e64f506b7844a
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip: irq/urgent] irqchip/riscv-imsic: Report successful hardware retrigger
2026-10-26 12:26 [PATCH] irqchip/riscv-imsic: Report successful hardware retrigger Avi Weiss
2026-10-27 9:53 ` Björn Töpel
2026-10-27 11:43 ` Anup Patel
@ 2026-10-28 20:29 ` tip-bot2 for Avi Weiss
2026-10-28 20:34 ` tip-bot2 for Avi Weiss
3 siblings, 0 replies; 5+ messages in thread
From: tip-bot2 for Avi Weiss @ 2026-10-28 20:29 UTC (permalink / raw)
To: linux-tip-commits
Cc: Avi Weiss, Thomas Gleixner, bjorn, Anup Patel, x86, linux-kernel, maz
The following commit has been merged into the irq/urgent branch of tip:
Commit-ID: 8ccba7c98f69009e64b9290f6ee4b2c0d2a87a4e
Gitweb: https://git.kernel.org/tip/8ccba7c98f69009e64b9290f6ee4b2c0d2a87a4e
Author: Avi Weiss <thnkslprpt@gmail.com>
AuthorDate: Mon, 26 Oct 2026 14:26:42 +02:00
Committer: Thomas Gleixner <tglx@kernel.org>
CommitterDate: Wed, 28 Oct 2026 21:24:51 +01:00
irqchip/riscv-imsic: Report successful hardware retrigger
imsic_irq_retrigger() writes to the IMSIC MSI register to retrigger
an interrupt, but returns 0. The IRQ core treats zero as failure and
may schedule a software resend despite the hardware retrigger.
Return 1 after the MSI write to report successful hardware
retriggering and prevent the unnecessary software resend.
Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Björn Töpel <bjorn@kernel.org>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://patch.msgid.link/20261026122641.3292904-2-thnkslprpt@gmail.com
---
drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
index 643c8e4..52673ff 100644
--- a/drivers/irqchip/irq-riscv-imsic-platform.c
+++ b/drivers/irqchip/irq-riscv-imsic-platform.c
@@ -61,7 +61,7 @@ static int imsic_irq_retrigger(struct irq_data *d)
local = per_cpu_ptr(imsic->global.local, vec->cpu);
writel_relaxed(vec->local_id, local->msi_va);
- return 0;
+ return 1;
}
static void imsic_irq_ack(struct irq_data *d)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip: irq/urgent] irqchip/riscv-imsic: Report successful hardware retrigger
2026-10-26 12:26 [PATCH] irqchip/riscv-imsic: Report successful hardware retrigger Avi Weiss
` (2 preceding siblings ...)
2026-10-28 20:29 ` [tip: irq/urgent] " tip-bot2 for Avi Weiss
@ 2026-10-28 20:34 ` tip-bot2 for Avi Weiss
3 siblings, 0 replies; 5+ messages in thread
From: tip-bot2 for Avi Weiss @ 2026-10-28 20:34 UTC (permalink / raw)
To: linux-tip-commits
Cc: Avi Weiss, Thomas Gleixner, bjorn, Anup Patel, stable, x86,
linux-kernel, maz
The following commit has been merged into the irq/urgent branch of tip:
Commit-ID: a2f482407d33ebe7f12e30d6cf383ffb1c7d709d
Gitweb: https://git.kernel.org/tip/a2f482407d33ebe7f12e30d6cf383ffb1c7d709d
Author: Avi Weiss <thnkslprpt@gmail.com>
AuthorDate: Mon, 26 Oct 2026 14:26:42 +02:00
Committer: Thomas Gleixner <tglx@kernel.org>
CommitterDate: Wed, 28 Oct 2026 21:29:36 +01:00
irqchip/riscv-imsic: Report successful hardware retrigger
imsic_irq_retrigger() writes to the IMSIC MSI register to retrigger
an interrupt, but returns 0. The IRQ core treats zero as failure and
may schedule a software resend despite the hardware retrigger.
Return 1 after the MSI write to report successful hardware
retriggering and prevent the unnecessary software resend.
Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Björn Töpel <bjorn@kernel.org>
Reviewed-by: Anup Patel <anup@brainfault.org>
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20261026122641.3292904-2-thnkslprpt@gmail.com
---
drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
index 643c8e4..52673ff 100644
--- a/drivers/irqchip/irq-riscv-imsic-platform.c
+++ b/drivers/irqchip/irq-riscv-imsic-platform.c
@@ -61,7 +61,7 @@ static int imsic_irq_retrigger(struct irq_data *d)
local = per_cpu_ptr(imsic->global.local, vec->cpu);
writel_relaxed(vec->local_id, local->msi_va);
- return 0;
+ return 1;
}
static void imsic_irq_ack(struct irq_data *d)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-10-28 20:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-26 12:26 [PATCH] irqchip/riscv-imsic: Report successful hardware retrigger Avi Weiss
2026-10-27 9:53 ` Björn Töpel
2026-10-27 11:43 ` Anup Patel
2026-10-28 20:29 ` [tip: irq/urgent] " tip-bot2 for Avi Weiss
2026-10-28 20:34 ` tip-bot2 for Avi Weiss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®