From: Kalle Valo <kvalo@kernel.org>
To: Yann Gautier <yann.gautier@foss.st.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
<linux-wireless@vger.kernel.org>,
Christophe ROULLIER-SCND-02 <christophe.roullier@foss.st.com>,
Arend van Spriel <aspriel@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Gustavo Padovan <gustavo.padovan@collabora.com>,
Adrian Ratiu <adrian.ratiu@collabora.com>,
<brcm80211-dev-list.pdl@broadcom.com>,
<linux-kernel@vger.kernel.org>,
Christophe KERELLO - foss <christophe.kerello@foss.st.com>
Subject: Re: [PATCH v2] brcmfmac: Avoid keeping power to SDIO card unless WOWL is used
Date: Wed, 23 Mar 2022 18:04:46 +0200 [thread overview]
Message-ID: <87a6dgk63l.fsf@kernel.org> (raw)
In-Reply-To: <51b4917b-823d-263a-2412-a4b17cb38420@foss.st.com> (Yann Gautier's message of "Wed, 23 Mar 2022 14:20:36 +0100")
Yann Gautier <yann.gautier@foss.st.com> writes:
> On 3/23/22 09:39, Ulf Hansson wrote:
>> Keeping the power to the SDIO card during system wide suspend, consumes
>> energy. Especially on battery driven embedded systems, this can be a
>> problem. Therefore, let's change the behaviour into allowing the SDIO card
>> to be powered off, unless WOWL is supported and enabled.
>>
>> Note that, the downside from this change, is that during system resume the
>> SDIO card needs to be re-initialized and the FW must be re-programmed. Even
>> if this may take some time to complete, it should we worth it, rather than
>> draining the battery.
>>
>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Thanks for the patch, it is OK, and tested by Christophe (R.).
> So you can add:
> Tested-by: Christophe Roullier <christophe.roullier@foss.st.com>
> Acked-by: Yann Gautier <yann.gautier@foss.st.com>
Acked-by is used by the driver maintainer, so I assume you mean
Reviewed-by?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-03-23 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 8:39 Ulf Hansson
2022-03-23 13:20 ` Yann Gautier
2022-03-23 16:04 ` Kalle Valo [this message]
2022-03-23 16:06 ` Yann Gautier
2022-04-06 12:11 ` [v2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6dgk63l.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=adrian.ratiu@collabora.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=christophe.kerello@foss.st.com \
--cc=christophe.roullier@foss.st.com \
--cc=franky.lin@broadcom.com \
--cc=gustavo.padovan@collabora.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yann.gautier@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®