From: Kalle Valo <kvalo@kernel.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-wireless@vger.kernel.org,
Yann Gautier <yann.gautier@foss.st.com>,
Arend van Spriel <aspriel@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Gustavo Padovan <gustavo.padovan@collabora.com>,
Adrian Ratiu <adrian.ratiu@collabora.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
brcm80211-dev-list.pdl@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [v2] brcmfmac: Avoid keeping power to SDIO card unless WOWL is used
Date: Wed, 6 Apr 2022 12:11:22 +0000 (UTC) [thread overview]
Message-ID: <164924707922.19026.4759219518482379162.kvalo@kernel.org> (raw)
In-Reply-To: <20220323083950.414783-1-ulf.hansson@linaro.org>
Ulf Hansson <ulf.hansson@linaro.org> wrote:
> Keeping the power to the SDIO card during system wide suspend, consumes
> energy. Especially on battery driven embedded systems, this can be a
> problem. Therefore, let's change the behaviour into allowing the SDIO card
> to be powered off, unless WOWL is supported and enabled.
>
> Note that, the downside from this change, is that during system resume the
> SDIO card needs to be re-initialized and the FW must be re-programmed. Even
> if this may take some time to complete, it should we worth it, rather than
> draining the battery.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> Tested-by: Christophe Roullier <christophe.roullier@foss.st.com>
> Reviewed-by: Yann Gautier <yann.gautier@foss.st.com>
Patch applied to wireless-next.git, thanks.
92cadedd9d5f brcmfmac: Avoid keeping power to SDIO card unless WOWL is used
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220323083950.414783-1-ulf.hansson@linaro.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-04-06 15:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 8:39 [PATCH v2] " Ulf Hansson
2022-03-23 13:20 ` Yann Gautier
2022-03-23 16:04 ` Kalle Valo
2022-03-23 16:06 ` Yann Gautier
2022-04-06 12:11 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164924707922.19026.4759219518482379162.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=adrian.ratiu@collabora.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=gustavo.padovan@collabora.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yann.gautier@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®