From: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Mike Tipton <mike.tipton@oss.qualcomm.com>
Subject: Re: [PATCH 1/3] dt-bindings: interconnect: add clocks property to enable QoS on qcs8300
Date: Wed, 24 Dec 2025 16:29:40 +0530 [thread overview]
Message-ID: <87b300a0-7ff6-4506-a27a-7a30e77c2bf6@oss.qualcomm.com> (raw)
In-Reply-To: <n7ucdvjlvst23zbbcwenp7umhn4wgsznqp23scpknwqnd6tcep@i6lhp7va325w>
On 12/24/2025 1:25 AM, Dmitry Baryshkov wrote:
> On Fri, Nov 28, 2025 at 08:31:04PM +0530, Odelu Kukatla wrote:
>> Add 'clocks' property to enable QoS configuration. This property
>> enables the necessary clocks for QoS configuration.
>>
>> QoS configuration is essential for ensuring that latency sensitive
>> components such as CPUs and multimedia engines receive prioritized
>> access to memory and interconnect resources. This helps to manage
>> bandwidth and latency across subsystems, improving system responsiveness
>> and performance in concurrent workloads.
>>
>> Both 'reg' and 'clocks' properties are optional. If either is missing,
>> QoS configuration will be skipped. This behavior is controlled by the
>> 'qos_requires_clocks' flag in the driver, which ensures that QoS
>> configuration is bypassed when required clocks are not defined.
>>
>> Signed-off-by: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
>> ---
>> .../interconnect/qcom,qcs8300-rpmh.yaml | 53 ++++++++++++++++---
>> 1 file changed, 47 insertions(+), 6 deletions(-)
>
> As a generic feedback for Qualcomm interconnect drivers (please pass it
> through the team):
>
> Please ensure that QoS-related clocks are defined in the first driver
> submission. DT bindings should describe the hardware and it's not that
> the hardware has changed between the time the first patches were
> submitted and this patchset.
>
> I see a typical pattern that QoS support is being submitted several
> months later. Why is it so? Why can't QoS be a part of the _same_
> patchset?
>
Hi Dmitry,
Thanks for feedback. we are ensuring that QoS-related clocks are defined
in the first driver submission like recently for Glymur/Kaanapali, there
were part of first driver submission.
QCS8300 and QCS615 are the only chip-sets, we are sending QoS patches
separately.
Thanks,
Odelu
next prev parent reply other threads:[~2025-12-24 10:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 15:01 [PATCH 0/3] Enable QoS configuration on QCS8300 Odelu Kukatla
2025-11-28 15:01 ` [PATCH 1/3] dt-bindings: interconnect: add clocks property to enable QoS on qcs8300 Odelu Kukatla
2025-11-28 16:19 ` Rob Herring (Arm)
2025-11-29 9:33 ` Krzysztof Kozlowski
2025-11-29 9:37 ` Krzysztof Kozlowski
2025-12-22 17:38 ` Odelu Kukatla
2025-12-23 13:45 ` Krzysztof Kozlowski
2026-01-03 18:42 ` Odelu Kukatla
2025-11-29 9:45 ` Krzysztof Kozlowski
2025-12-22 17:45 ` Odelu Kukatla
2025-12-23 19:55 ` Dmitry Baryshkov
2025-12-24 10:59 ` Odelu Kukatla [this message]
2025-11-28 15:01 ` [PATCH 2/3] interconnect: qcom: qcs8300: enable QoS configuration Odelu Kukatla
2025-11-29 1:20 ` Dmitry Baryshkov
2025-12-01 15:06 ` Konrad Dybcio
2025-11-28 15:01 ` [PATCH 3/3] arm64: dts: qcom: qcs8300: Add clocks for " Odelu Kukatla
2025-11-29 1:16 ` Dmitry Baryshkov
2025-11-29 9:34 ` Krzysztof Kozlowski
2025-12-22 16:57 ` Odelu Kukatla
2025-12-01 15:09 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87b300a0-7ff6-4506-a27a-7a30e77c2bf6@oss.qualcomm.com \
--to=odelu.kukatla@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mike.tipton@oss.qualcomm.com \
--cc=raviteja.laggyshetty@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®