mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>,
	luto@amacapital.net, shuahkh@osg.samsung.com
Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
	khilman@kernel.org, broonie@kernel.org,
	bamvor.zhangjian@huawei.com, bamvor.zhangjian@linaro.org
Subject: Re: [PATCH 1/2] selftests: fix the broken individual test for x86
Date: Tue, 28 Mar 2017 11:22:53 +1100	[thread overview]
Message-ID: <87bmsm8d2a.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20170327054601.22415-2-bamvor.zhangjian@linaro.org>

Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> writes:

> Andy Lutomirski report that build individual testcase in x86 is broken:
>
> $ make -C tools/testing/selftests/x86 ldt_gdt_32
> make: Entering directory '/home/luto/apps/linux/tools/testing/selftests/x86'
> Makefile:44: warning: overriding recipe for target 'clean'
> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
> make: *** No rule to make target 'ldt_gdt_32'.  Stop.
> make: Leaving directory '/home/luto/apps/linux/tools/testing/selftests/x86'
>
> This patch fix this issue by adding default OUTPUT and convert
> target in Makefile of x86.
>
> And also mention this use case in Documentation/kselftests.txt
>
> Reported-by: Andy Lutomirski <luto@amacapital.net>
> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
> ---
>  Documentation/kselftest.txt          |  6 ++++++
>  tools/testing/selftests/x86/Makefile | 23 ++++++++++++++---------
>  2 files changed, 20 insertions(+), 9 deletions(-)

I don't think this is a good fix, it only fixes this one Makefile, and
it's quite verbose. But if it really bothers Andy then it would be OK as
a stop-gap for 4.11.

cheers

  reply	other threads:[~2017-03-28  0:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27  5:45 [PATCH 0/2] selftests: fix for KBUILD_OUTPUT Bamvor Jian Zhang
2017-03-27  5:46 ` [PATCH 1/2] selftests: fix the broken individual test for x86 Bamvor Jian Zhang
2017-03-28  0:22   ` Michael Ellerman [this message]
2017-03-28 11:33     ` Bamvor Zhang Jian
2017-03-27  5:46 ` [PATCH 2/2] selftests: net: support KBUILD_OUTPUT for reuseport_bpf_numa Bamvor Jian Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmsm8d2a.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=bamvor.zhangjian@huawei.com \
    --cc=bamvor.zhangjian@linaro.org \
    --cc=broonie@kernel.org \
    --cc=khilman@kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®