From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Huaitong Han <huaitong.han@intel.com>
Cc: linux-kernel@vger.kernel.org,
Huaitong Han <huaitong.han@intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
mingo@redhat.com, acme@kernel.org
Subject: Re: [PATCH] RDMSR before test_cpu_capacity brings about KVM warning
Date: Mon, 17 Aug 2015 15:04:16 +0300 [thread overview]
Message-ID: <87bne6jf3z.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <1439546857-12791-1-git-send-email-huaitong.han@intel.com>
Huaitong Han <huaitong.han@intel.com> writes:
> rdmsrl_safe does not lead to #GP in native kernel although CPU
> does not support INTEL_PT, but if KVM does not support INTEL_PT,
> the codes cannot understand MSR_IA32_RTIT_CTL, and the warning
> is produced.
"the codes"?
> If KVM does not support INTEL_PT, its guest CPUID also does not.
> So test_cpu_cap is added before RDMSR, and it is more in line with
> the code style.
It does make more sense like this, but please improve this commit
message. And don't forget to include Peter in the loop.
FWIW,
Reviewed-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Regards,
--
Alex
next prev parent reply other threads:[~2015-08-17 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 10:07 Huaitong Han
2015-08-17 12:04 ` Alexander Shishkin [this message]
2015-08-17 13:23 ` Han, Huaitong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bne6jf3z.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=huaitong.han@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®