From: Rusty Russell <rusty@ozlabs.org>
To: Jason Vas Dias <jason.vas.dias@gmail.com>, linux-kernel@vger.kernel.org
Cc: Andreas Herrmann <herrmann.der.user@googlemail.com>,
Matthew Garrett <mjg@redhat.com>, Len Brown <lenb@kernel.org>,
Comrade DOS <suloevdmitry@gmail.com>
Subject: Re: [PATCH: 1/1] ACPI: make evaluation of thermal trip points before temperature or vice versa dependant on new "temp_b4_trip" module parameter to support older AMD x86_64s
Date: Mon, 09 Jul 2012 10:00:27 +0930 [thread overview]
Message-ID: <87bojp3hek.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CALyZvKyEiTaU4CDh3F-fYkSjyyFkmhjitaWmXs_PORVEeOnirw@mail.gmail.com>
On Sun, 8 Jul 2012 19:50:54 +0100, Jason Vas Dias <jason.vas.dias@gmail.com> wrote:
> This patch adds a new acpi.thermal.temp_b4_trip = 1 settting, which
> causes the temperature
> to be set before evaluation of thermal trip points (the old default) ;
> this mode should
> be selected automatically by DMI match if the system identifies as "HP
> Compaq 6715b" .
>
> Please consider applying a patch like that attached to fix the issue reported
> in lkml thread "Re: PROBLEM: Performance drop" recently, whereby
> it was found that HP 6715b laptops ( which have 2.2Ghz dual-core AMD
> x86_64 k8 CPUs)
> get stuck running the CPU at 800Khz and cannot switch frequency. I have verified
> that this still the case with v3.4.4 tagged "stable" kernel.
>
> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> index 7dbebea..de2b164 100644
> --- a/drivers/acpi/thermal.c
> +++ b/drivers/acpi/thermal.c
> @@ -96,6 +96,10 @@ static int psv;
> module_param(psv, int, 0644);
> MODULE_PARM_DESC(psv, "Disable or override all passive trip points.");
>
> +static int temp_b4_trip;
> +module_param(temp_b4_trip, int, 0);
> +MODULE_PARM_DESC(temp_b4_trip, "Get the temperature before
> initializing trip points.");
> +
Hi Jason,
Two points: this is a bool, why not make it one? I know, the
rest of the code is old-school, but this is a new parameter. Also, why
not 0644 so it can be read and set at runtime?
Cheers,
Rusty.
next prev parent reply other threads:[~2012-07-09 0:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 18:50 Jason Vas Dias
2012-07-09 0:30 ` Rusty Russell [this message]
2012-07-09 18:16 ` Jason Vas Dias
2012-07-10 0:06 ` Rusty Russell
2012-07-14 11:45 Jason Vas Dias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bojp3hek.fsf@rustcorp.com.au \
--to=rusty@ozlabs.org \
--cc=herrmann.der.user@googlemail.com \
--cc=jason.vas.dias@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=suloevdmitry@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome