mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Srivatsa Vaddagiri <vatsa@in.ibm.com>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	Nathan Lynch <nathanl@austin.ibm.com>,
	Joel Schopp <jschopp@austin.ibm.com>,
	Ashok Raj <ashok.raj@intel.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Subject: [BUG] cpu-hotplug: Can't offline the CPU with naughty realtime processes
Date: Mon, 07 May 2007 19:10:05 +0900	[thread overview]
Message-ID: <87bqgxrlky.wl%takeuchi_satoru@jp.fujitsu.com> (raw)

Hi,

I found a bug on 2.6.21 cpu-hotplug code.

When process A on CPU0 try to offline the CPU1 on which the process B,
realtime process (its task->policy == SCHED_FIFO or SCHED_RR) running
without sleep or yield, both CPU0 and CPU1 get hang. It's because of
the following code on __stop_machine_run().

struct task_struct *__stop_machine_run(int (*fn)(void *), void *data,
				       unsigned int cpu)
{
	...
	p = kthread_create(do_stop, &smdata, "kstopmachine");
	if (!IS_ERR(p)) {
		kthread_bind(p, cpu);
		wake_up_process(p);
		wait_for_completion(&smdata.done);
	}
	...
}

kstopmachine is created, bound to the CPU1, and woken up here, but
this process can't start to run because reschedule doesn't occur on
CPU1. Hence CPU0 also be able to run because it's waiting completion
of CPU1's offline work.

Thanks,

Sat

             reply	other threads:[~2007-05-07 10:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-07 10:10 Satoru Takeuchi [this message]
2007-05-07 10:47 ` Gautham R Shenoy
2007-05-07 11:02   ` Srivatsa Vaddagiri
2007-05-07 12:39     ` Gautham R Shenoy
2007-05-07 10:55 ` Srivatsa Vaddagiri
2007-05-07 10:56 ` KAMEZAWA Hiroyuki
2007-05-07 13:42 ` Rusty Russell
2007-05-08  2:41   ` Satoru Takeuchi
2007-05-08  3:02     ` Rusty Russell
2007-05-08  3:29       ` Satoru Takeuchi
2007-05-08  4:04         ` Rusty Russell
2007-05-08  4:10         ` Srivatsa Vaddagiri
2007-05-08  7:16           ` Satoru Takeuchi
2007-05-08 16:48             ` Srivatsa Vaddagiri
2007-05-09  0:40               ` Satoru Takeuchi
2007-05-09  0:47                 ` Nick Piggin
2007-05-09  6:31                   ` Satoru Takeuchi
2007-05-09  8:56                   ` Gautham R Shenoy
2007-05-11  8:49       ` [PATCH 1/2] Fix stop_machine_run problem with naughty real time process Satoru Takeuchi
2007-05-11  9:18         ` Satoru Takeuchi
2007-05-11  8:49       ` [PATCH 2/2] cpu hotplug: fix ksoftirqd termination on cpu hotplug with naughty realtime process Satoru Takeuchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bqgxrlky.wl%takeuchi_satoru@jp.fujitsu.com \
    --to=takeuchi_satoru@jp.fujitsu.com \
    --cc=ashok.raj@intel.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jschopp@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathanl@austin.ibm.com \
    --cc=rusty@rustcorp.com.au \
    --cc=vatsa@in.ibm.com \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®