From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
Nathan Lynch <nathanl@austin.ibm.com>,
Joel Schopp <jschopp@austin.ibm.com>,
Ashok Raj <ashok.raj@intel.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Gautham R Shenoy <ego@in.ibm.com>
Subject: [PATCH 2/2] cpu hotplug: fix ksoftirqd termination on cpu hotplug with naughty realtime process
Date: Fri, 11 May 2007 17:49:27 +0900 [thread overview]
Message-ID: <87tzujeodk.wl%takeuchi_satoru@jp.fujitsu.com> (raw)
In-Reply-To: <1178593345.28438.29.camel@localhost.localdomain>
Fix ksoftirqd termination on cpu hotplug with naughty real time process.
Assuming the following case:
- Try to hot remove CPU2 from CPU1.
- There is a real time process on CPU2, and that process doesn't sleep at all.
- That rt process and ksoftirqd/2 is migrated to the CPU0
Then ksoftirqd/2 can't stop becasue that rt process runs everlastingly on CPU0,
and CPU1 waiting the ksoftirqd/2's termination hangs up. To fix this problem, set
the priority of ksoftirqd/2 to max one before kthread_stop().
Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Index: linux-2.6.21/kernel/softirq.c
===================================================================
--- linux-2.6.21.orig/kernel/softirq.c 2007-05-11 13:45:34.000000000 +0900
+++ linux-2.6.21/kernel/softirq.c 2007-05-11 17:19:12.000000000 +0900
@@ -590,6 +590,7 @@ static int __cpuinit cpu_callback(struct
{
int hotcpu = (unsigned long)hcpu;
struct task_struct *p;
+ struct sched_param param = { .sched_priority = MAX_RT_PRIO-1 };
switch (action) {
case CPU_UP_PREPARE:
@@ -614,6 +615,7 @@ static int __cpuinit cpu_callback(struct
case CPU_DEAD:
p = per_cpu(ksoftirqd, hotcpu);
per_cpu(ksoftirqd, hotcpu) = NULL;
+ sched_setscheduler(p, SCHED_FIFO, ¶m);
kthread_stop(p);
takeover_tasklets(hotcpu);
break;
prev parent reply other threads:[~2007-05-11 8:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 10:10 [BUG] cpu-hotplug: Can't offline the CPU with naughty realtime processes Satoru Takeuchi
2007-05-07 10:47 ` Gautham R Shenoy
2007-05-07 11:02 ` Srivatsa Vaddagiri
2007-05-07 12:39 ` Gautham R Shenoy
2007-05-07 10:55 ` Srivatsa Vaddagiri
2007-05-07 10:56 ` KAMEZAWA Hiroyuki
2007-05-07 13:42 ` Rusty Russell
2007-05-08 2:41 ` Satoru Takeuchi
2007-05-08 3:02 ` Rusty Russell
2007-05-08 3:29 ` Satoru Takeuchi
2007-05-08 4:04 ` Rusty Russell
2007-05-08 4:10 ` Srivatsa Vaddagiri
2007-05-08 7:16 ` Satoru Takeuchi
2007-05-08 16:48 ` Srivatsa Vaddagiri
2007-05-09 0:40 ` Satoru Takeuchi
2007-05-09 0:47 ` Nick Piggin
2007-05-09 6:31 ` Satoru Takeuchi
2007-05-09 8:56 ` Gautham R Shenoy
2007-05-11 8:49 ` [PATCH 1/2] Fix stop_machine_run problem with naughty real time process Satoru Takeuchi
2007-05-11 9:18 ` Satoru Takeuchi
2007-05-11 8:49 ` Satoru Takeuchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tzujeodk.wl%takeuchi_satoru@jp.fujitsu.com \
--to=takeuchi_satoru@jp.fujitsu.com \
--cc=ashok.raj@intel.com \
--cc=ego@in.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathanl@austin.ibm.com \
--cc=rusty@rustcorp.com.au \
--cc=vatsa@in.ibm.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®