mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] ALSA: hda/realtek: Fix internal mic on Minisforum V3 and V3 SE
@ 2026-09-28 15:29 Jared Wuerzburger
  2026-09-28 15:41 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Jared Wuerzburger @ 2026-09-28 15:29 UTC (permalink / raw)
  To: Takashi Iwai, Jaroslav Kysela
  Cc: linux-sound, linux-kernel, Samuel Dionne-Riel, Jared Wuerzburger, stable

On the Minisforum V3 and V3 SE (ALC245, PCI SSID 1f4c:e001) the
internal digital microphone array never produces any audio. The DMIC
pin 0x12 is parsed correctly ("Internal Mic=0x12"), but the headset mic
jack pin 0x19 (BIOS pin config 0x04a19050, jack detect enabled) has no
presence detect wired on these boards: reading GET_PIN_SENSE on 0x19
always returns "present" (as it does on the unused, unconnected pin
0x18), while the headphone jack 0x21 reports correctly.

The generic parser therefore sets up auto-mic switching and, believing
an external mic is always plugged in, permanently routes the ADC to the
empty jack (mixer 0x23 input 0x19 unmuted, input 0x12 muted). The
"Mic Jack" kcontrol reports "on" with nothing plugged in.

Mark pin 0x19 as having no presence detect. The parser then stops
auto-switching and exposes a normal "Capture Source" (Internal Mic /
Mic) control, which desktop audio stacks drive from their Internal
Microphone / Microphone ports. The existing bass speaker DAC routing is
kept by chaining to ALC245_FIXUP_BASS_HP_DAC.

Tested on both models with the same pin config applied through a
snd-hda-intel patch firmware ([pincfg] 0x19 0x04a19150):
 - V3 SE (Ryzen 7 7735U, BIOS 1.03), kernel 7.2.6
 - V3 (Ryzen 7 8840U, BIOS 1.06), kernel 7.2.7
Both boards report the same codec SSID and the same 0x19 default. On
both, the internal mic records at a normal level, headphone jack
detection on 0x21 still switches output, and the bass routing is
retained (DAC1/DAC2 Playback Volume controls present). A headset mic
on the combo jack was not tested (none available); with this change it
has to be selected manually. V3 users already report that the jack mic
gets no input [1], which is the other symptom of the same broken
presence detect.

The patched alc269.c was build-tested with W=1 on tiwai/sound.git
for-linus (7.3-rc3) without new warnings.

The diagnosis, the fixup and this changelog were written with the help
of an AI coding assistant; I reviewed them and tested the change on the
hardware listed above.

Fixes: e34743018249 ("ALSA: hda/realtek: Add quirk for Minisforum V3 SE")
Link: https://github.com/mudkipme/awesome-minisforum-v3/issues/14 [1]
Cc: stable@vger.kernel.org
Assisted-by: LLM
Signed-off-by: Jared Wuerzburger <jwuerz@gmail.com>
---
Changes in v2:
- Drop the alc269_fixup_models[] entry (Takashi)
- Add Fixes: tag for the commit that added the V3 (SE) quirk (Takashi)
- Assisted-by: LLM (Takashi)
- v1: https://lore.kernel.org/linux-sound/20260927173237.339476-1-jwuerz@gmail.com/

 sound/hda/codecs/realtek/alc269.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 5127a111c5..d9ce10d5d3 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -4384,6 +4384,7 @@ enum {
 	ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN_HEADSET,
 	ALC285_LENOVO_DAC_RENAME,
 	ALC287_FIXUP_YOGA9_SPEAKER2_TO_DAC1,
+	ALC245_FIXUP_MINISFORUM_V3_MIC_NO_PRESENCE,
 };
 
 /* A special fixup for Lenovo C940 and Yoga Duet 7;
@@ -7136,6 +7137,15 @@ static const struct hda_fixup alc269_fixups[] = {
 		.chained = true,
 		.chain_id = ALC287_FIXUP_TXNW2781_I2C,
 	},
+	[ALC245_FIXUP_MINISFORUM_V3_MIC_NO_PRESENCE] = {
+		.type = HDA_FIXUP_PINS,
+		.v.pins = (const struct hda_pintbl[]) {
+			{ 0x19, 0x04a19150 }, /* headset mic jack, no presence detect */
+			{ }
+		},
+		.chained = true,
+		.chain_id = ALC245_FIXUP_BASS_HP_DAC
+	},
 };
 
 static const struct hda_quirk alc269_fixup_tbl[] = {
@@ -8349,7 +8359,8 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1ee7, 0x2081, "HONOR MRB-XXX M1020", ALC256_FIXUP_HONOR_MRB_XXX_M1020_AUDIO),
 	SND_PCI_QUIRK(0x1f4c, 0xb020, "Minisforum AI X1 Pro",
 		      ALC245_FIXUP_MINISFORUM_JACK_DETECT),
-	SND_PCI_QUIRK(0x1f4c, 0xe001, "Minisforum V3 (SE)", ALC245_FIXUP_BASS_HP_DAC),
+	SND_PCI_QUIRK(0x1f4c, 0xe001, "Minisforum V3 (SE)",
+		      ALC245_FIXUP_MINISFORUM_V3_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1f66, 0x0105, "Ayaneo Portable Game Player", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x2014, 0x800a, "Positivo ARN50", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
 	SND_PCI_QUIRK(0x2039, 0x0001, "Inspur S14-G1", ALC295_FIXUP_CHROME_BOOK),
-- 
2.55.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] ALSA: hda/realtek: Fix internal mic on Minisforum V3 and V3 SE
  2026-09-28 15:29 [PATCH v2] ALSA: hda/realtek: Fix internal mic on Minisforum V3 and V3 SE Jared Wuerzburger
@ 2026-09-28 15:41 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-09-28 15:41 UTC (permalink / raw)
  To: Jared Wuerzburger
  Cc: Takashi Iwai, Jaroslav Kysela, linux-sound, linux-kernel,
	Samuel Dionne-Riel, stable

On Mon, 28 Sep 2026 17:29:25 +0200,
Jared Wuerzburger wrote:
> 
> On the Minisforum V3 and V3 SE (ALC245, PCI SSID 1f4c:e001) the
> internal digital microphone array never produces any audio. The DMIC
> pin 0x12 is parsed correctly ("Internal Mic=0x12"), but the headset mic
> jack pin 0x19 (BIOS pin config 0x04a19050, jack detect enabled) has no
> presence detect wired on these boards: reading GET_PIN_SENSE on 0x19
> always returns "present" (as it does on the unused, unconnected pin
> 0x18), while the headphone jack 0x21 reports correctly.
> 
> The generic parser therefore sets up auto-mic switching and, believing
> an external mic is always plugged in, permanently routes the ADC to the
> empty jack (mixer 0x23 input 0x19 unmuted, input 0x12 muted). The
> "Mic Jack" kcontrol reports "on" with nothing plugged in.
> 
> Mark pin 0x19 as having no presence detect. The parser then stops
> auto-switching and exposes a normal "Capture Source" (Internal Mic /
> Mic) control, which desktop audio stacks drive from their Internal
> Microphone / Microphone ports. The existing bass speaker DAC routing is
> kept by chaining to ALC245_FIXUP_BASS_HP_DAC.
> 
> Tested on both models with the same pin config applied through a
> snd-hda-intel patch firmware ([pincfg] 0x19 0x04a19150):
>  - V3 SE (Ryzen 7 7735U, BIOS 1.03), kernel 7.2.6
>  - V3 (Ryzen 7 8840U, BIOS 1.06), kernel 7.2.7
> Both boards report the same codec SSID and the same 0x19 default. On
> both, the internal mic records at a normal level, headphone jack
> detection on 0x21 still switches output, and the bass routing is
> retained (DAC1/DAC2 Playback Volume controls present). A headset mic
> on the combo jack was not tested (none available); with this change it
> has to be selected manually. V3 users already report that the jack mic
> gets no input [1], which is the other symptom of the same broken
> presence detect.
> 
> The patched alc269.c was build-tested with W=1 on tiwai/sound.git
> for-linus (7.3-rc3) without new warnings.
> 
> The diagnosis, the fixup and this changelog were written with the help
> of an AI coding assistant; I reviewed them and tested the change on the
> hardware listed above.
> 
> Fixes: e34743018249 ("ALSA: hda/realtek: Add quirk for Minisforum V3 SE")
> Link: https://github.com/mudkipme/awesome-minisforum-v3/issues/14 [1]
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Jared Wuerzburger <jwuerz@gmail.com>
> ---
> Changes in v2:
> - Drop the alc269_fixup_models[] entry (Takashi)
> - Add Fixes: tag for the commit that added the V3 (SE) quirk (Takashi)
> - Assisted-by: LLM (Takashi)
> - v1: https://lore.kernel.org/linux-sound/20260927173237.339476-1-jwuerz@gmail.com/

Applied now to for-next branch.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-28 15:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-28 15:29 [PATCH v2] ALSA: hda/realtek: Fix internal mic on Minisforum V3 and V3 SE Jared Wuerzburger
2026-09-28 15:41 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®