From: Marc Zyngier <maz@kernel.org>
To: Julian Braha <julianbraha@gmail.com>
Cc: florian.fainelli@broadcom.com, rjui@broadcom.com,
sbranden@broadcom.com, linux@armlinux.org.uk, tglx@kernel.org,
Frank.Li@nxp.com, s.hauer@pengutronix.de,
bcm-kernel-feedback-list@broadcom.com, radu@rendec.net,
kernel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev, arnd@arndb.de,
sudeep.holla@kernel.org, mark.rutland@arm.com,
lpieralisi@kernel.org
Subject: Re: [PATCH v2] irqchip: gic-v3: fix unmet dependency on ARM_PSCI_FW
Date: Mon, 24 Aug 2026 17:07:33 +0100 [thread overview]
Message-ID: <87cxv7o62i.wl-maz@kernel.org> (raw)
In-Reply-To: <20260823180832.1246363-1-julianbraha@gmail.com>
On Sun, 23 Aug 2026 19:08:32 +0100,
Julian Braha <julianbraha@gmail.com> wrote:
>
> ARM_GIC_V3 currently selects HAVE_ARM_SMCCC_DISCOVERY without ensuring its
> dependency, ARM_PSCI_FW, is met. However, ARM_PSCI_FW is always enabled on
> for arm64, and the GICv3 driver only uses HAVE_ARM_SMCCC_DISCOVERY to
> identify the NVIDIA T241, which is arm64 anyway.
>
> Also adds fallbacks for callers to avoid needing #ifdef guards when
> HAVE_ARM_SMCCC_DISCOVERY is disabled (32bit arm).
What does this 'Also' tell you? That this part is in the wrong patch.
This should be split in two different patches, fixing different
problems. One to allow graceful fallback of the SMCCC_DISCOVERY stuff
when it isn't selected, and another to only force the selection of
that option on arm64 when GICv3 is selected.
>
> This unmet dependency was found by kconfirm, a static analysis tool for
> Kconfig.
I'm not sure this is massively relevant here, but since the trend is
to turn commit messages into advertising billboards...
M.
--
Jazz isn't dead. It just smells funny.
next prev parent reply other threads:[~2026-08-24 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-23 18:08 Julian Braha
2026-08-24 16:07 ` Marc Zyngier [this message]
2026-08-24 19:00 ` Julian Braha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cxv7o62i.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=imx@lists.linux.dev \
--cc=julianbraha@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=radu@rendec.net \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=sudeep.holla@kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®