[PATCH] fix grammar on false-sharing.rst

[PATCH] fix grammar on false-sharing.rst

[Vishnu Sanal T]

fix the grammar mistakes on kernel-hacking/false-sharing.rst

Signed-off-by: Vishnu Sanal T <t.v.s10123@gmail.com>
---
 Documentation/kernel-hacking/false-sharing.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/kernel-hacking/false-sharing.rst b/Documentation/kernel-hacking/false-sharing.rst
index 122b0e124656..ad7cb60bef29 100644
--- a/Documentation/kernel-hacking/false-sharing.rst
+++ b/Documentation/kernel-hacking/false-sharing.rst
@@ -196,9 +196,9 @@ the hotspot switches to a new place.
 
 Miscellaneous
 =============
-One open issue is that kernel has an optional data structure
-randomization mechanism, which also randomizes the situation of cache
-line sharing of data members.
+One open issue is that the kernel has an optional data structure
+randomization mechanism, which also randomize the situation of cache
+line sharing among data members.
 
 
 .. [1] https://en.wikipedia.org/wiki/False_sharing
-- 
2.46.2

Re: [PATCH] fix grammar on false-sharing.rst

[Jonathan Corbet]

Vishnu Sanal T <t.v.s10123@gmail.com> writes:

> fix the grammar mistakes on kernel-hacking/false-sharing.rst
>
> Signed-off-by: Vishnu Sanal T <t.v.s10123@gmail.com>
> ---
>  Documentation/kernel-hacking/false-sharing.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/kernel-hacking/false-sharing.rst b/Documentation/kernel-hacking/false-sharing.rst
> index 122b0e124656..ad7cb60bef29 100644
> --- a/Documentation/kernel-hacking/false-sharing.rst
> +++ b/Documentation/kernel-hacking/false-sharing.rst
> @@ -196,9 +196,9 @@ the hotspot switches to a new place.
>  
>  Miscellaneous
>  =============
> -One open issue is that kernel has an optional data structure
> -randomization mechanism, which also randomizes the situation of cache
> -line sharing of data members.
> +One open issue is that the kernel has an optional data structure

So here you are fixing a problem, which is good

> +randomization mechanism, which also randomize the situation of cache

But here you are introducing a new one, which is a bit less so....?

> +line sharing among data members.

Thanks,

jon

[PATCH v2] fix grammar on false-sharing.rst

[Vishnu Sanal T]

Fix slight grammar mistake on kernel-hacking/false-sharing.rst

Signed-off-by: Vishnu Sanal T <t.v.s10123@gmail.com>
---
Changes in v2:

- revert inadverdent mistake introduced on the word "randomizes"
---
 Documentation/kernel-hacking/false-sharing.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/kernel-hacking/false-sharing.rst b/Documentation/kernel-hacking/false-sharing.rst
index 122b0e124656..eb0596734e55 100644
--- a/Documentation/kernel-hacking/false-sharing.rst
+++ b/Documentation/kernel-hacking/false-sharing.rst
@@ -196,9 +196,9 @@ the hotspot switches to a new place.
 
 Miscellaneous
 =============
-One open issue is that kernel has an optional data structure
+One open issue is that the kernel has an optional data structure
 randomization mechanism, which also randomizes the situation of cache
-line sharing of data members.
+line sharing among data members.
 
 
 .. [1] https://en.wikipedia.org/wiki/False_sharing
-- 
2.46.2

Re: [PATCH v2] fix grammar on false-sharing.rst

[Jonathan Corbet]

Vishnu Sanal T <t.v.s10123@gmail.com> writes:

> Fix slight grammar mistake on kernel-hacking/false-sharing.rst
>
> Signed-off-by: Vishnu Sanal T <t.v.s10123@gmail.com>
> ---
> Changes in v2:
>
> - revert inadverdent mistake introduced on the word "randomizes"
> ---
>  Documentation/kernel-hacking/false-sharing.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/kernel-hacking/false-sharing.rst b/Documentation/kernel-hacking/false-sharing.rst
> index 122b0e124656..eb0596734e55 100644
> --- a/Documentation/kernel-hacking/false-sharing.rst
> +++ b/Documentation/kernel-hacking/false-sharing.rst
> @@ -196,9 +196,9 @@ the hotspot switches to a new place.
>  
>  Miscellaneous
>  =============
> -One open issue is that kernel has an optional data structure
> +One open issue is that the kernel has an optional data structure
>  randomization mechanism, which also randomizes the situation of cache
> -line sharing of data members.
> +line sharing among data members.
>  
Applied, thanks.

jon