mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/4] scripts: add stackusage script
Date: Thu, 25 Jun 2015 10:04:00 +0200	[thread overview]
Message-ID: <87egl08b9r.fsf@rasmusvillemoes.dk> (raw)
In-Reply-To: <558964EE.7090009@suse.cz> (Michal Marek's message of "Tue, 23 Jun 2015 15:53:50 +0200")

On Tue, Jun 23 2015, Michal Marek <mmarek@suse.cz> wrote:

>
> EXTRA_CFLAGS is reserved for use by Makefiles, please use KCFLAGS
> instead.

Will do, thanks. Maybe Documentation/SubmitChecklist and
Documentation/development-process/4.Coding wants to be updated.

> I wonder whether it worked at all, because EXTRA_CFLAGS is
> reset by scripts/Makefile.build.

It did indeed work, but only because I passed the setting on the make
command line and not via the environment. I think one needs an override
directive to actually override the settings from the command line:

$ cat Makefile 
VAR1 := a1
VAR2 := a2
override VAR3 := a3
override VAR4 := a4

all:
        @echo $(VAR1) $(VAR2) $(VAR3) $(VAR4)
$ VAR1=b1 VAR3=b3 make VAR2=b2 VAR4=b4 all
a1 b2 a3 a4

  reply	other threads:[~2015-06-25  8:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1434849046-19920-1-git-send-email-linux@rasmusvillemoes.dk>
2015-06-21  1:10 ` Rasmus Villemoes
2015-06-23 13:53   ` Michal Marek
2015-06-25  8:04     ` Rasmus Villemoes [this message]
2015-06-21  1:10 ` [RFC 2/4] .gitignore: add *.su pattern Rasmus Villemoes
2015-06-21  1:10 ` [RFC 3/4] kbuild: remove *.su files generated by -fstack-usage Rasmus Villemoes
2015-06-21  1:10 ` [RFC 4/4] scripts: add stackdelta script Rasmus Villemoes
2015-06-22  7:39   ` Rasmus Villemoes
     [not found] ` <1435220492-15868-1-git-send-email-linux@rasmusvillemoes.dk>
2015-06-25  8:21   ` [RFC v2 1/4] scripts: add stackusage script Rasmus Villemoes
2015-06-25  8:21   ` [RFC v2 2/4] .gitignore: add *.su pattern Rasmus Villemoes
2015-06-25  8:21   ` [RFC v2 3/4] kbuild: remove *.su files generated by -fstack-usage Rasmus Villemoes
2015-06-25  8:21   ` [RFC v2 4/4] scripts: add stackdelta script Rasmus Villemoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87egl08b9r.fsf@rasmusvillemoes.dk \
    --to=linux@rasmusvillemoes.dk \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®