From: Rusty Russell <rusty@rustcorp.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pawel Moll <pawel.moll@arm.com>
Subject: Re: [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc)
Date: Mon, 09 Jan 2012 16:56:36 +1030 [thread overview]
Message-ID: <87ehv99ysj.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAMuHMdVYhVnxuvhThpeqcaazkSJQJBtrwrxwJc0=y_hV_7PsNg@mail.gmail.com>
On Fri, 6 Jan 2012 13:31:40 +0100, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Hi Rusty,
>
> On Thu, Dec 15, 2011 at 04:18, Rusty Russell <rusty@rustcorp.com.au> wrote:
> > diff --git a/drivers/block/paride/bpck6.c b/drivers/block/paride/bpck6.c
> > --- a/drivers/block/paride/bpck6.c
> > +++ b/drivers/block/paride/bpck6.c
> > @@ -21,7 +21,7 @@
> >
> >
> > /* PARAMETERS */
> > -static int verbose; /* set this to 1 to see debugging messages and whatnot */
> > +static bool verbose; /* set this to 1 to see debugging messages and whatnot */
>
> "bool" doesn't exist at this point, cfr.
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/5325550/
> http://kisskb.ellerman.id.au/kisskb/buildresult/5325257/
>
> Any chance this is going to be fixed before it's sucked in Linus'
> tree?
Of course, done (moved declaration and comment below #includes).
Thanks!
Rusty.
prev parent reply other threads:[~2012-01-09 7:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 3:18 Rusty Russell
2012-01-03 12:44 ` Dan Carpenter
2012-01-04 2:27 ` Rusty Russell
2012-01-03 12:58 ` Dan Carpenter
2012-01-03 13:17 ` [patch] TPM: handle errors from probe_itpm() Dan Carpenter
2012-01-04 2:29 ` [PATCH] intelfbdrv.c: bailearly is an int module_param Rusty Russell
2012-01-04 2:30 ` [PATCH] paride/pcd: fix bool verbose module parameter Rusty Russell
2012-01-04 7:12 ` [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc) Tomi Valkeinen
2012-01-05 0:03 ` Rusty Russell
2012-01-06 12:31 ` Geert Uytterhoeven
2012-01-09 6:26 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehv99ysj.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome