From: Rusty Russell <rusty@rustcorp.com.au>
To: Tim Waugh <tim@cyberelk.net>
Cc: linux-kernel@vger.kernel.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Subject: [PATCH] paride/pcd: fix bool verbose module parameter.
Date: Wed, 04 Jan 2012 13:00:42 +1030 [thread overview]
Message-ID: <87zke4ci7h.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20120103131748.GA11575@elgon.mountain>
Dan Carpenter points out that it's an int, not a bool:
pcd.c:427: if (verbose > 1)
pcd.c:433: if (verbose > 1)
pcd.c:437: if (verbose < 2)
pcd.c:506:#define DBMSG(msg) ((verbose>1)?(msg):NULL)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/block/paride/pcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c
--- a/drivers/block/paride/pcd.c
+++ b/drivers/block/paride/pcd.c
@@ -144,7 +144,7 @@ enum {D_PRT, D_PRO, D_UNI, D_MOD, D_SLV,
static DEFINE_MUTEX(pcd_mutex);
static DEFINE_SPINLOCK(pcd_lock);
-module_param(verbose, bool, 0644);
+module_param(verbose, int, 0644);
module_param(major, int, 0);
module_param(name, charp, 0);
module_param(nice, int, 0);
next prev parent reply other threads:[~2012-01-04 2:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 3:18 [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc) Rusty Russell
2012-01-03 12:44 ` Dan Carpenter
2012-01-04 2:27 ` Rusty Russell
2012-01-03 12:58 ` Dan Carpenter
2012-01-03 13:17 ` [patch] TPM: handle errors from probe_itpm() Dan Carpenter
2012-01-04 2:29 ` [PATCH] intelfbdrv.c: bailearly is an int module_param Rusty Russell
2012-01-04 2:30 ` Rusty Russell [this message]
2012-01-04 7:12 ` [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc) Tomi Valkeinen
2012-01-05 0:03 ` Rusty Russell
2012-01-06 12:31 ` Geert Uytterhoeven
2012-01-09 6:26 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zke4ci7h.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome