mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: helios4: add #phy-cells to USB nop phys
@ 2026-08-31 23:36 Rosen Penev
  2026-09-30  6:35 ` Gregory CLEMENT
  0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-08-31 23:36 UTC (permalink / raw)
  To: devicetree
  Cc: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley,
	moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...,
	open list

The usb-nop-xceiv binding requires a #phy-cells property; without it
dtbs_check reports:

  usb2-phy: '#phy-cells' is a required property (usb-nop-xceiv)
  usb3-phy: '#phy-cells' is a required property (usb-nop-xceiv)

Add #phy-cells = <0> to both nodes. No functional change.

Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 arch/arm/boot/dts/marvell/armada-388-helios4.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
index e63b8b5e632d..548fb92ca811 100644
--- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
+++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
@@ -141,10 +141,12 @@ fan2: j17-pwm {
 	usb2_phy: usb2-phy {
 		compatible = "usb-nop-xceiv";
 		vbus-supply = <&reg_5p0v_usb>;
+		#phy-cells = <0>;
 	};
 
 	usb3_phy: usb3-phy {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 	};
 
 	soc {
-- 
2.55.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: helios4: add #phy-cells to USB nop phys
  2026-08-31 23:36 [PATCH] ARM: dts: helios4: add #phy-cells to USB nop phys Rosen Penev
@ 2026-09-30  6:35 ` Gregory CLEMENT
  0 siblings, 0 replies; 2+ messages in thread
From: Gregory CLEMENT @ 2026-09-30  6:35 UTC (permalink / raw)
  To: Rosen Penev, devicetree
  Cc: Andrew Lunn, Sebastian Hesselbarth, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley,
	moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...,
	open list

Rosen Penev <rosenp@gmail.com> writes:

> The usb-nop-xceiv binding requires a #phy-cells property; without it
> dtbs_check reports:
>
>   usb2-phy: '#phy-cells' is a required property (usb-nop-xceiv)
>   usb3-phy: '#phy-cells' is a required property (usb-nop-xceiv)
>
> Add #phy-cells = <0> to both nodes. No functional change.
>
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Applied on mvebu/dt

Thanks,

Gregory
> ---
>  arch/arm/boot/dts/marvell/armada-388-helios4.dts | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> index e63b8b5e632d..548fb92ca811 100644
> --- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> +++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> @@ -141,10 +141,12 @@ fan2: j17-pwm {
>  	usb2_phy: usb2-phy {
>  		compatible = "usb-nop-xceiv";
>  		vbus-supply = <&reg_5p0v_usb>;
> +		#phy-cells = <0>;
>  	};
>  
>  	usb3_phy: usb3-phy {
>  		compatible = "usb-nop-xceiv";
> +		#phy-cells = <0>;
>  	};
>  
>  	soc {
> -- 
> 2.55.0
>

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-30  6:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-31 23:36 [PATCH] ARM: dts: helios4: add #phy-cells to USB nop phys Rosen Penev
2026-09-30  6:35 ` Gregory CLEMENT

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®