mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/intel: Add Star Lite Mk II/III to power_save_denylist
@ 2026-07-29 12:55 Zhang Heng
  2026-07-29 13:58 ` Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: Zhang Heng @ 2026-07-29 12:55 UTC (permalink / raw)
  To: tiwai; +Cc: linux-sound, linux-kernel, Zhang Heng

The Star Lite Mk II (0x10ec, 0x111e) exhibits a pop sound
when the speakers are used after a period of inactivity.

This can be resolved by disabling the HDA power save feature
via "options snd-hda-intel power_save=0". Add the device to
the power_save_denylist to apply this workaround automatically.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=206623
Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
---
 sound/hda/controllers/intel.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/hda/controllers/intel.c b/sound/hda/controllers/intel.c
index 9a5c61f43011..eda89ac83262 100644
--- a/sound/hda/controllers/intel.c
+++ b/sound/hda/controllers/intel.c
@@ -2316,6 +2316,8 @@ static const struct snd_pci_quirk power_save_denylist[] = {
 	SND_PCI_QUIRK(0x17aa, 0x5079, "Lenovo Thinkpad E15", 0),
 	/* https://bugzilla.kernel.org/show_bug.cgi?id=220694 */
 	SND_PCI_QUIRK(0x103c, 0x8a6b, "HP 89E9", 0),
+	/* https://bugzilla.kernel.org/show_bug.cgi?id=206623 */
+	SND_PCI_QUIRK(0x10ec, 0x111e, "Star Lite Mk II/III", 0),
 	{}
 };
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: hda/intel: Add Star Lite Mk II/III to power_save_denylist
  2026-07-29 12:55 [PATCH] ALSA: hda/intel: Add Star Lite Mk II/III to power_save_denylist Zhang Heng
@ 2026-07-29 13:58 ` Takashi Iwai
  2026-07-30  2:10   ` Zhang Heng
  0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2026-07-29 13:58 UTC (permalink / raw)
  To: Zhang Heng; +Cc: tiwai, linux-sound, linux-kernel

On Wed, 29 Jul 2026 14:55:44 +0200,
Zhang Heng wrote:
> 
> The Star Lite Mk II (0x10ec, 0x111e) exhibits a pop sound
> when the speakers are used after a period of inactivity.
> 
> This can be resolved by disabling the HDA power save feature
> via "options snd-hda-intel power_save=0". Add the device to
> the power_save_denylist to apply this workaround automatically.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206623
> Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>

Is the problem verified with the latest kernel?  The report above
looks very old, and it's not sure whether the problem really persists
or not.

In general, the power-save deny-list is a kind of last resort.
Usually the pop noise problem could be resolved in the codec driver
side.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: hda/intel: Add Star Lite Mk II/III to power_save_denylist
  2026-07-29 13:58 ` Takashi Iwai
@ 2026-07-30  2:10   ` Zhang Heng
  0 siblings, 0 replies; 3+ messages in thread
From: Zhang Heng @ 2026-07-30  2:10 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: tiwai, linux-sound, linux-kernel


> Is the problem verified with the latest kernel?  The report above
> looks very old, and it's not sure whether the problem really persists
> or not.
> 
> In general, the power-save deny-list is a kind of last resort.
> Usually the pop noise problem could be resolved in the codec driver
> side.

Based on the SSID of the sound card, I have not seen any relevant fix,
so the problem likely still exists in the latest kernel. I agree with
your point, but most current driver fixes address pop noise during
power-on/off or playback; I have not found any similar fix for capture
(recording) pops. It appears that many users default to the `power_save`
workaround – I also previously disabled power-saving mode to mitigate
the issue. For future encounters with similar recording pop noise,
I will try alternative solutions rather than relying solely on
`power_save`.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-30  2:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-29 12:55 [PATCH] ALSA: hda/intel: Add Star Lite Mk II/III to power_save_denylist Zhang Heng
2026-07-29 13:58 ` Takashi Iwai
2026-07-30  2:10   ` Zhang Heng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome