* [PATCH] riscv: fix build warning of missing prototypes
@ 2020-06-01 3:55 Zong Li
2020-06-01 6:47 ` Andreas Schwab
2020-06-05 0:01 ` Palmer Dabbelt
0 siblings, 2 replies; 4+ messages in thread
From: Zong Li @ 2020-06-01 3:55 UTC (permalink / raw)
To: paul.walmsley, palmer, linux-riscv, linux-kernel
Cc: Zong Li, kbuild test robot
Add the missing header in file, it was losed in original implementation.
The warning message as follows:
- no previous prototype for 'patch_text_nosync' [-Wmissing-prototypes]
- no previous prototype for 'patch_text' [-Wmissing-prototypes]
Signed-off-by: Zong Li <zong.li@sifive.com>
Reported-by: kbuild test robot <lkp@intel.com>
---
arch/riscv/kernel/patch.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/riscv/kernel/patch.c b/arch/riscv/kernel/patch.c
index 5805791cd5b5..d4a64dfed342 100644
--- a/arch/riscv/kernel/patch.c
+++ b/arch/riscv/kernel/patch.c
@@ -11,6 +11,7 @@
#include <asm/kprobes.h>
#include <asm/cacheflush.h>
#include <asm/fixmap.h>
+#include <asm/patch.h>
struct patch_insn {
void *addr;
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] riscv: fix build warning of missing prototypes
2020-06-01 3:55 [PATCH] riscv: fix build warning of missing prototypes Zong Li
@ 2020-06-01 6:47 ` Andreas Schwab
2020-06-01 6:56 ` Zong Li
2020-06-05 0:01 ` Palmer Dabbelt
1 sibling, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2020-06-01 6:47 UTC (permalink / raw)
To: Zong Li
Cc: paul.walmsley, palmer, linux-riscv, linux-kernel, kbuild test robot
On Jun 01 2020, Zong Li wrote:
> Add the missing header in file, it was losed in original implementation.
s/losed/lost/
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: fix build warning of missing prototypes
2020-06-01 6:47 ` Andreas Schwab
@ 2020-06-01 6:56 ` Zong Li
0 siblings, 0 replies; 4+ messages in thread
From: Zong Li @ 2020-06-01 6:56 UTC (permalink / raw)
To: Andreas Schwab
Cc: Paul Walmsley, Palmer Dabbelt, linux-riscv,
linux-kernel@vger.kernel.org List, kbuild test robot
On Mon, Jun 1, 2020 at 2:48 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Jun 01 2020, Zong Li wrote:
>
> > Add the missing header in file, it was losed in original implementation.
>
> s/losed/lost/
>
> Andreas.
Thanks for correcting, let me modify it in the next version.
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
> "And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: fix build warning of missing prototypes
2020-06-01 3:55 [PATCH] riscv: fix build warning of missing prototypes Zong Li
2020-06-01 6:47 ` Andreas Schwab
@ 2020-06-05 0:01 ` Palmer Dabbelt
1 sibling, 0 replies; 4+ messages in thread
From: Palmer Dabbelt @ 2020-06-05 0:01 UTC (permalink / raw)
To: zong.li; +Cc: Paul Walmsley, linux-riscv, linux-kernel, zong.li, lkp
On Sun, 31 May 2020 20:55:32 PDT (-0700), zong.li@sifive.com wrote:
> Add the missing header in file, it was losed in original implementation.
>
> The warning message as follows:
> - no previous prototype for 'patch_text_nosync' [-Wmissing-prototypes]
> - no previous prototype for 'patch_text' [-Wmissing-prototypes]
>
> Signed-off-by: Zong Li <zong.li@sifive.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> ---
> arch/riscv/kernel/patch.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/kernel/patch.c b/arch/riscv/kernel/patch.c
> index 5805791cd5b5..d4a64dfed342 100644
> --- a/arch/riscv/kernel/patch.c
> +++ b/arch/riscv/kernel/patch.c
> @@ -11,6 +11,7 @@
> #include <asm/kprobes.h>
> #include <asm/cacheflush.h>
> #include <asm/fixmap.h>
> +#include <asm/patch.h>
>
> struct patch_insn {
> void *addr;
Thanks, this one is queued up -- for-next is in flux right now, but with any
luck it'll get sorted out soon.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-05 0:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-01 3:55 [PATCH] riscv: fix build warning of missing prototypes Zong Li
2020-06-01 6:47 ` Andreas Schwab
2020-06-01 6:56 ` Zong Li
2020-06-05 0:01 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®