From: Eric Anholt <eric@anholt.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/vc4: Drop debug print at boot with DPI enabled.
Date: Wed, 15 Feb 2017 12:56:16 -0800 [thread overview]
Message-ID: <87fujfjhqn.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20170209171115.njqhfot7so4vb7ed@phenom.ffwll.local>
[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]
Daniel Vetter <daniel@ffwll.ch> writes:
> On Wed, Feb 08, 2017 at 12:47:01PM -0800, Eric Anholt wrote:
>> Unlike the other encoders in the driver, I've also dropped the debug
>> dump function. There's only really one register to this device, and
>> we have the debugfs reg entry still.
>>
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>
> Yeah, dmesg spew by default isn't cool. Btw if you ever want to have fancy
> debug printers, there's drm_printer, which allows you to spam both dmesg
> and debugfs with the same code. Rob did that, I recently converted drm_mm,
> it's pretty cool.
>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Merged to -next, thanks.
The drm printer stuff looks really promising! I'm also interested,
though, in the debugfs_regset32 stuff that lets you just name your regs
in a struct and pass it and your regs base address to the helper for
creating the debugfs entry. I bet we can mash those two ideas together
into something really nice.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2017-02-15 20:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 20:47 Eric Anholt
2017-02-09 17:11 ` Daniel Vetter
2017-02-15 20:56 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fujfjhqn.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®