* [PATCH] ALSA: hda/realtek: Fix incorrect comment for ALC299_FIXUP_PREDATOR_SPK
@ 2026-05-22 6:07 Zhang Heng
2026-05-25 7:21 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Heng @ 2026-05-22 6:07 UTC (permalink / raw)
To: perex, tiwai; +Cc: linux-sound, linux-kernel, Zhang Heng
The comment for the pin configuration 0x21 in the fixup
ALC299_FIXUP_PREDATOR_SPK states "use as headset mic, without its own
jack detect", but the fixup name and the actual usage indicate that the
pin is meant to be used as internal speaker. Correct the comment to
avoid confusion.
Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
---
sound/hda/codecs/realtek/alc269.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 2b150bb5c7a8..f617084da482 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -5471,7 +5471,7 @@ static const struct hda_fixup alc269_fixups[] = {
[ALC299_FIXUP_PREDATOR_SPK] = {
.type = HDA_FIXUP_PINS,
.v.pins = (const struct hda_pintbl[]) {
- { 0x21, 0x90170150 }, /* use as headset mic, without its own jack detect */
+ { 0x21, 0x90170150 }, /* use as internal speaker */
{ }
}
},
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-25 7:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-22 6:07 [PATCH] ALSA: hda/realtek: Fix incorrect comment for ALC299_FIXUP_PREDATOR_SPK Zhang Heng
2026-05-25 7:21 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®