* [PATCH] Documentation/vm/page_owner.rst: fix commends
@ 2022-02-23 13:41 Yixuan Cao
2022-02-23 17:16 ` Randy Dunlap
2022-02-24 19:18 ` Jonathan Corbet
0 siblings, 2 replies; 3+ messages in thread
From: Yixuan Cao @ 2022-02-23 13:41 UTC (permalink / raw)
To: corbet
Cc: akpm, sfr, hanshenghong2019, weizhenliang, georgi.djakov, skhan,
linux-doc, linux-kernel, Yixuan Cao
There are some commends that need to be fixed.
Thanks for Shuah Khan's constructive suggestions.
The commends have been fixed as follows.
a. So, if you'd like to use it, you need
to add "page_owner=on" into your boot cmdline.
Here, "into" has been replaced with "to".
b. ...page owner is disabled in runtime due to no
enabling, boot option, runtime overhead is marginal.
Here, "no" has been replaced with "not".
Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
---
Documentation/vm/page_owner.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/vm/page_owner.rst b/Documentation/vm/page_owner.rst
index 2b54e82b9fe1..aec1906976f4 100644
--- a/Documentation/vm/page_owner.rst
+++ b/Documentation/vm/page_owner.rst
@@ -26,9 +26,9 @@ fragmentation statistics can be obtained through gfp flag information of
each page. It is already implemented and activated if page owner is
enabled. Other usages are more than welcome.
-page owner is disabled in default. So, if you'd like to use it, you need
-to add "page_owner=on" into your boot cmdline. If the kernel is built
-with page owner and page owner is disabled in runtime due to no enabling
+page owner is disabled by default. So, if you'd like to use it, you need
+to add "page_owner=on" to your boot cmdline. If the kernel is built
+with page owner and page owner is disabled in runtime due to not enabling
boot option, runtime overhead is marginal. If disabled in runtime, it
doesn't require memory to store owner information, so there is no runtime
memory overhead. And, page owner inserts just two unlikely branches into
--
2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation/vm/page_owner.rst: fix commends
2022-02-23 13:41 [PATCH] Documentation/vm/page_owner.rst: fix commends Yixuan Cao
@ 2022-02-23 17:16 ` Randy Dunlap
2022-02-24 19:18 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2022-02-23 17:16 UTC (permalink / raw)
To: Yixuan Cao, corbet
Cc: akpm, sfr, hanshenghong2019, weizhenliang, georgi.djakov, skhan,
linux-doc, linux-kernel
Hi,
On 2/23/22 05:41, Yixuan Cao wrote:
> There are some commends that need to be fixed.
>
> Thanks for Shuah Khan's constructive suggestions.
> The commends have been fixed as follows.
>
> a. So, if you'd like to use it, you need
> to add "page_owner=on" into your boot cmdline.
>
> Here, "into" has been replaced with "to".
>
> b. ...page owner is disabled in runtime due to no
> enabling, boot option, runtime overhead is marginal.
>
> Here, "no" has been replaced with "not".
>
> Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
The file changes look good.
The Subject and patch description should use "comments"
instead of "commends".
thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Documentation/vm/page_owner.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/vm/page_owner.rst b/Documentation/vm/page_owner.rst
> index 2b54e82b9fe1..aec1906976f4 100644
> --- a/Documentation/vm/page_owner.rst
> +++ b/Documentation/vm/page_owner.rst
> @@ -26,9 +26,9 @@ fragmentation statistics can be obtained through gfp flag information of
> each page. It is already implemented and activated if page owner is
> enabled. Other usages are more than welcome.
>
> -page owner is disabled in default. So, if you'd like to use it, you need
> -to add "page_owner=on" into your boot cmdline. If the kernel is built
> -with page owner and page owner is disabled in runtime due to no enabling
> +page owner is disabled by default. So, if you'd like to use it, you need
> +to add "page_owner=on" to your boot cmdline. If the kernel is built
> +with page owner and page owner is disabled in runtime due to not enabling
> boot option, runtime overhead is marginal. If disabled in runtime, it
> doesn't require memory to store owner information, so there is no runtime
> memory overhead. And, page owner inserts just two unlikely branches into
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation/vm/page_owner.rst: fix commends
2022-02-23 13:41 [PATCH] Documentation/vm/page_owner.rst: fix commends Yixuan Cao
2022-02-23 17:16 ` Randy Dunlap
@ 2022-02-24 19:18 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2022-02-24 19:18 UTC (permalink / raw)
To: Yixuan Cao
Cc: akpm, sfr, hanshenghong2019, weizhenliang, georgi.djakov, skhan,
linux-doc, linux-kernel, Yixuan Cao
Yixuan Cao <caoyixuan2019@email.szu.edu.cn> writes:
> There are some commends that need to be fixed.
>
> Thanks for Shuah Khan's constructive suggestions.
> The commends have been fixed as follows.
>
> a. So, if you'd like to use it, you need
> to add "page_owner=on" into your boot cmdline.
>
> Here, "into" has been replaced with "to".
>
> b. ...page owner is disabled in runtime due to no
> enabling, boot option, runtime overhead is marginal.
>
> Here, "no" has been replaced with "not".
>
> Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
> ---
> Documentation/vm/page_owner.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied (with some changelog cleanups), thanks.
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-24 19:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-23 13:41 [PATCH] Documentation/vm/page_owner.rst: fix commends Yixuan Cao
2022-02-23 17:16 ` Randy Dunlap
2022-02-24 19:18 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®