mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Andy Lutomirski <luto@amacapital.net>, linux-kernel@vger.kernel.org
Cc: Andy Lutomirski <luto@amacapital.net>, stable@vger.kernel.org
Subject: Re: [PATCH] module: Clean up ro/nx after early module load failures
Date: Sat, 16 Aug 2014 04:19:19 +0930	[thread overview]
Message-ID: <87ha1d8u6o.fsf@rustcorp.com.au> (raw)
In-Reply-To: <8c275067bad7333e82cb80c993ce23216f41002e.1408065737.git.luto@amacapital.net>

Andy Lutomirski <luto@amacapital.net> writes:
> The commit
>
>     4982223e51e8 module: set nx before marking module MODULE_STATE_COMING.
>
> introduced a regression: if a module fails to parse its arguments or
> if mod_sysfs_setup fails, then the module's memory will be freed
> while still read-only.  Anything that reuses that memory will crash
> as soon as it tries to write to it.

Thanks, good catch.

Applied,
Rusty.

       reply	other threads:[~2014-08-15 19:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8c275067bad7333e82cb80c993ce23216f41002e.1408065737.git.luto@amacapital.net>
2014-08-15 18:49 ` Rusty Russell [this message]
2014-08-15 19:26   ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ha1d8u6o.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®