* Re: [PATCH] module: Clean up ro/nx after early module load failures
[not found] <8c275067bad7333e82cb80c993ce23216f41002e.1408065737.git.luto@amacapital.net>
@ 2014-08-15 18:49 ` Rusty Russell
2014-08-15 19:26 ` Andy Lutomirski
0 siblings, 1 reply; 2+ messages in thread
From: Rusty Russell @ 2014-08-15 18:49 UTC (permalink / raw)
To: Andy Lutomirski, linux-kernel; +Cc: Andy Lutomirski, stable
Andy Lutomirski <luto@amacapital.net> writes:
> The commit
>
> 4982223e51e8 module: set nx before marking module MODULE_STATE_COMING.
>
> introduced a regression: if a module fails to parse its arguments or
> if mod_sysfs_setup fails, then the module's memory will be freed
> while still read-only. Anything that reuses that memory will crash
> as soon as it tries to write to it.
Thanks, good catch.
Applied,
Rusty.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] module: Clean up ro/nx after early module load failures
2014-08-15 18:49 ` [PATCH] module: Clean up ro/nx after early module load failures Rusty Russell
@ 2014-08-15 19:26 ` Andy Lutomirski
0 siblings, 0 replies; 2+ messages in thread
From: Andy Lutomirski @ 2014-08-15 19:26 UTC (permalink / raw)
To: Rusty Russell; +Cc: linux-kernel, stable
On Fri, Aug 15, 2014 at 11:49 AM, Rusty Russell <rusty@rustcorp.com.au> wrote:
> Andy Lutomirski <luto@amacapital.net> writes:
>> The commit
>>
>> 4982223e51e8 module: set nx before marking module MODULE_STATE_COMING.
>>
>> introduced a regression: if a module fails to parse its arguments or
>> if mod_sysfs_setup fails, then the module's memory will be freed
>> while still read-only. Anything that reuses that memory will crash
>> as soon as it tries to write to it.
>
> Thanks, good catch.
Catching it was easy. Figuring out wtf was happening to my poor
computer, on the other hand... :)
>
> Applied,
> Rusty.
--
Andy Lutomirski
AMA Capital Management, LLC
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-15 19:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <8c275067bad7333e82cb80c993ce23216f41002e.1408065737.git.luto@amacapital.net>
2014-08-15 18:49 ` [PATCH] module: Clean up ro/nx after early module load failures Rusty Russell
2014-08-15 19:26 ` Andy Lutomirski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®