A question on printascii

A question on printascii

[Shashidhar Hiremath]

HI,
  I want to use printascii to debug my serial driver. How do I enable
it and use the feature.
  Currently I have enabled in menuconfig and done an extern on the
printascii api, this doesn't seem to work, So any hints for debugging
serial drivers ?

-- 
regards,
Shashidhar Hiremath

Re: A question on printascii

[Randy Dunlap]

On 07/18/2012 06:03 AM, Shashidhar Hiremath wrote:

> HI,
>   I want to use printascii to debug my serial driver. How do I enable
> it and use the feature.
>   Currently I have enabled in menuconfig and done an extern on the
> printascii api, this doesn't seem to work, So any hints for debugging
> serial drivers ?
> 


Enabled what/where in menuconfig?

It looks like only a few CPU architecures or platforms
implement "printascii".  What architecture/platform are you trying
to use it on?

-- 
~Randy

Re: A question on printascii

[Shashidhar Hiremath]

I am working on ARM architecture.

On Wed, Jul 18, 2012 at 9:33 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On 07/18/2012 06:03 AM, Shashidhar Hiremath wrote:
>
>> HI,
>>   I want to use printascii to debug my serial driver. How do I enable
>> it and use the feature.
>>   Currently I have enabled in menuconfig and done an extern on the
>> printascii api, this doesn't seem to work, So any hints for debugging
>> serial drivers ?
>>
>
>
> Enabled what/where in menuconfig?
>
> It looks like only a few CPU architecures or platforms
> implement "printascii".  What architecture/platform are you trying
> to use it on?
>
> --
> ~Randy



-- 
regards,
Shashidhar Hiremath

Re: A question on printascii

[Chris Ball]

Hi Shashidhar,

On Wed, Jul 18 2012, Shashidhar Hiremath wrote:
>   I want to use printascii to debug my serial driver. How do I enable
> it and use the feature.
>   Currently I have enabled in menuconfig and done an extern on the
> printascii api, this doesn't seem to work, So any hints for debugging
> serial drivers ?

Sounds like you want this patch, against linux-next:

diff --git a/kernel/printk.c b/kernel/printk.c
index 3991862..36abce8 100644
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -45,6 +45,8 @@
 
 #include <asm/uaccess.h>
 
+extern void printascii(char *);
+
 #define CREATE_TRACE_POINTS
 #include <trace/events/printk.h>
 
@@ -1542,6 +1544,8 @@ asmlinkage int vprintk_emit(int facility, int level,
 	 */
 	text_len = vscnprintf(text, sizeof(textbuf), fmt, args);
 
+	printascii(text);
+
 	/* mark and strip a trailing newline */
 	if (text_len && text[text_len-1] == '\n') {
 		text_len--;

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

Re: A question on printascii

[Shashidhar Hiremath]

thanks a lot Chris. Will try it out.

On Fri, Jul 20, 2012 at 9:24 AM, Chris Ball <cjb@laptop.org> wrote:
> Hi Shashidhar,
>
> On Wed, Jul 18 2012, Shashidhar Hiremath wrote:
>>   I want to use printascii to debug my serial driver. How do I enable
>> it and use the feature.
>>   Currently I have enabled in menuconfig and done an extern on the
>> printascii api, this doesn't seem to work, So any hints for debugging
>> serial drivers ?
>
> Sounds like you want this patch, against linux-next:
>
> diff --git a/kernel/printk.c b/kernel/printk.c
> index 3991862..36abce8 100644
> --- a/kernel/printk.c
> +++ b/kernel/printk.c
> @@ -45,6 +45,8 @@
>
>  #include <asm/uaccess.h>
>
> +extern void printascii(char *);
> +
>  #define CREATE_TRACE_POINTS
>  #include <trace/events/printk.h>
>
> @@ -1542,6 +1544,8 @@ asmlinkage int vprintk_emit(int facility, int level,
>          */
>         text_len = vscnprintf(text, sizeof(textbuf), fmt, args);
>
> +       printascii(text);
> +
>         /* mark and strip a trailing newline */
>         if (text_len && text[text_len-1] == '\n') {
>                 text_len--;
>
> --
> Chris Ball   <cjb@laptop.org>   <http://printf.net/>
> One Laptop Per Child



-- 
regards,
Shashidhar Hiremath