* [PATCH] smc911x: Re-release spinlock on spurious interrupt
@ 2006-07-20 3:59 Peter Korsgaard
2006-07-20 4:01 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Peter Korsgaard @ 2006-07-20 3:59 UTC (permalink / raw)
To: dustin, netdev; +Cc: linux-kernel
Hi,
The smc911x driver forgets to release the spinlock on spurious
interrupts. This little patch fixes it.
diff -Naur linux-2.6.18-rc2.orig/drivers/net/smc911x.c linux-2.6.18-rc2/drivers/net/smc911x.c
--- linux-2.6.18-rc2.orig/drivers/net/smc911x.c 2006-07-20 10:26:20.000000000 +0200
+++ linux-2.6.18-rc2/drivers/net/smc911x.c 2006-07-20 17:44:26.000000000 +0200
@@ -1092,6 +1092,7 @@
/* Spurious interrupt check */
if ((SMC_GET_IRQ_CFG() & (INT_CFG_IRQ_INT_ | INT_CFG_IRQ_EN_)) !=
(INT_CFG_IRQ_INT_ | INT_CFG_IRQ_EN_)) {
+ spin_unlock_irqrestore(&lp->lock, flags);
return IRQ_NONE;
}
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] smc911x: Re-release spinlock on spurious interrupt
2006-07-20 3:59 [PATCH] smc911x: Re-release spinlock on spurious interrupt Peter Korsgaard
@ 2006-07-20 4:01 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2006-07-20 4:01 UTC (permalink / raw)
To: dustin; +Cc: netdev, linux-kernel
>>>>> "Peter" == Peter Korsgaard <jacmet@sunsite.dk> writes:
Peter> Hi,
Peter> The smc911x driver forgets to release the spinlock on spurious
Peter> interrupts. This little patch fixes it.
Crap - forgot to sign off :/
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
diff -Naur linux-2.6.18-rc2.orig/drivers/net/smc911x.c linux-2.6.18-rc2/drivers/net/smc911x.c
--- linux-2.6.18-rc2.orig/drivers/net/smc911x.c 2006-07-20 10:26:20.000000000 +0200
+++ linux-2.6.18-rc2/drivers/net/smc911x.c 2006-07-20 17:44:26.000000000 +0200
@@ -1092,6 +1092,7 @@
/* Spurious interrupt check */
if ((SMC_GET_IRQ_CFG() & (INT_CFG_IRQ_INT_ | INT_CFG_IRQ_EN_)) !=
(INT_CFG_IRQ_INT_ | INT_CFG_IRQ_EN_)) {
+ spin_unlock_irqrestore(&lp->lock, flags);
return IRQ_NONE;
}
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-07-20 16:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-07-20 3:59 [PATCH] smc911x: Re-release spinlock on spurious interrupt Peter Korsgaard
2006-07-20 4:01 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®