From: "Björn Töpel" <bjorn@kernel.org>
To: Guo Ren <guoren@kernel.org>
Cc: palmer@dabbelt.com, paul.walmsley@sifive.com,
mhiramat@kernel.org, conor.dooley@microchip.com,
penberg@kernel.org, mark.rutland@arm.com,
liaochang <liaochang1@huawei.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Guo Ren <guoren@linux.alibaba.com>
Subject: Re: [PATCH] riscv: kprobe: Fixup kernel panic when probing an illegal position
Date: Thu, 02 Feb 2023 09:32:13 +0100 [thread overview]
Message-ID: <87ilgk79iq.fsf@all.your.base.are.belong.to.us> (raw)
In-Reply-To: <CAJF2gTTn52FWRU9-ZqDLpTUe0BkLgttP3NOyk-PzxJbbX75cPg@mail.gmail.com>
Guo Ren <guoren@kernel.org> writes:
>> > - tmp += GET_INSN_LENGTH(*(kprobe_opcode_t *)tmp);
>> > + memcpy(&opcode, (void *)tmp, sizeof(kprobe_opcode_t));
>> > + tmp += GET_INSN_LENGTH(opcode);
>>
>> I'd prefer sizeof(opcode).
> prefer sizeof(opcode) = 4
>
> GET_INSN_LENGTH(opcode) returns 2 or 4;
Sorry for being unclear. I was referring to the sizeof in the memcpy.
next prev parent reply other threads:[~2023-02-02 8:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 13:05 guoren
2023-01-28 2:55 ` liaochang (A)
2023-01-28 3:46 ` Guo Ren
2023-01-28 3:52 ` Guo Ren
2023-01-28 9:53 ` liaochang (A)
2023-01-28 5:22 ` Guo Ren
2023-01-28 9:53 ` liaochang (A)
2023-01-31 12:32 ` Björn Töpel
2023-01-31 13:01 ` Guo Ren
2023-02-01 2:57 ` Guo Ren
2023-02-01 9:30 ` Björn Töpel
2023-02-02 6:06 ` Guo Ren
2023-02-02 8:32 ` Björn Töpel [this message]
2023-02-01 3:49 ` liaochang (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilgk79iq.fsf@all.your.base.are.belong.to.us \
--to=bjorn@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=liaochang1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®