mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH RFC] ALSA: IEC958 definition for consumer status channel update
@ 2024-09-06  9:34 Jerome Brunet
  2024-09-06 12:25 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Jerome Brunet @ 2024-09-06  9:34 UTC (permalink / raw)
  To: Takashi Iwai, Jaroslav Kysela; +Cc: Jerome Brunet, linux-sound, linux-kernel

Add 128kHz, 352.4kHz, 384kHz and 705.6kHz.
These definitions have been found working on eARC using a Murideo
Seven Generator.

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---

 Hi,

 As explained in the commit description, I don't a have strong references
 to back the new values up. I've found them through testing.

 The value must exist somehow since the related sample rates are allowed
 over an IEC958 link. It would be better to get confirmation from the
 actual specification rather than just rely on testing.

 I don't mind if this does not get applied. I just want to make the
 data public, giving others the possibility to confirm or deny it.

 include/sound/asoundef.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/sound/asoundef.h b/include/sound/asoundef.h
index 9fdeac19dadb..09b2c3dffb30 100644
--- a/include/sound/asoundef.h
+++ b/include/sound/asoundef.h
@@ -110,18 +110,22 @@
 #define IEC958_AES2_CON_SOURCE_UNSPEC	(0<<0)	/* unspecified */
 #define IEC958_AES2_CON_CHANNEL		(15<<4)	/* mask - channel number */
 #define IEC958_AES2_CON_CHANNEL_UNSPEC	(0<<4)	/* unspecified */
-#define IEC958_AES3_CON_FS		(15<<0)	/* mask - sample frequency */
+#define IEC958_AES3_CON_FS		((1<<7) | (15<<0)) /* mask - sample frequency */
 #define IEC958_AES3_CON_FS_44100	(0<<0)	/* 44.1kHz */
 #define IEC958_AES3_CON_FS_NOTID	(1<<0)	/* non indicated */
 #define IEC958_AES3_CON_FS_48000	(2<<0)	/* 48kHz */
 #define IEC958_AES3_CON_FS_32000	(3<<0)	/* 32kHz */
 #define IEC958_AES3_CON_FS_22050	(4<<0)	/* 22.05kHz */
+#define IEC958_AES3_CON_FS_384000	(5<<0)	/* 384kHz */
 #define IEC958_AES3_CON_FS_24000	(6<<0)	/* 24kHz */
 #define IEC958_AES3_CON_FS_88200	(8<<0)	/* 88.2kHz */
 #define IEC958_AES3_CON_FS_768000	(9<<0)	/* 768kHz */
 #define IEC958_AES3_CON_FS_96000	(10<<0)	/* 96kHz */
 #define IEC958_AES3_CON_FS_176400	(12<<0)	/* 176.4kHz */
+#define IEC958_AES3_CON_FS_352400	(13<<0) /* 352.4kHz */
 #define IEC958_AES3_CON_FS_192000	(14<<0)	/* 192kHz */
+#define IEC958_AES3_CON_FS_128000	((1<<7) | (11<<0)) /* 128kHz */
+#define IEC958_AES3_CON_FS_705600	((1<<7) | (13<<0)) /* 705.6kHz */
 #define IEC958_AES3_CON_CLOCK		(3<<4)	/* mask - clock accuracy */
 #define IEC958_AES3_CON_CLOCK_1000PPM	(0<<4)	/* 1000 ppm */
 #define IEC958_AES3_CON_CLOCK_50PPM	(1<<4)	/* 50 ppm */
-- 
2.45.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH RFC] ALSA: IEC958 definition for consumer status channel update
  2024-09-06  9:34 [PATCH RFC] ALSA: IEC958 definition for consumer status channel update Jerome Brunet
@ 2024-09-06 12:25 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-09-06 12:25 UTC (permalink / raw)
  To: Jerome Brunet; +Cc: Takashi Iwai, Jaroslav Kysela, linux-sound, linux-kernel

On Fri, 06 Sep 2024 11:34:16 +0200,
Jerome Brunet wrote:
> 
> Add 128kHz, 352.4kHz, 384kHz and 705.6kHz.
> These definitions have been found working on eARC using a Murideo
> Seven Generator.
> 
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> 
>  Hi,
> 
>  As explained in the commit description, I don't a have strong references
>  to back the new values up. I've found them through testing.
> 
>  The value must exist somehow since the related sample rates are allowed
>  over an IEC958 link. It would be better to get confirmation from the
>  actual specification rather than just rely on testing.
> 
>  I don't mind if this does not get applied. I just want to make the
>  data public, giving others the possibility to confirm or deny it.

I find it makes sense to have definitions.  At least, it doesn't break
alone :)

Unless anyone raises objection, I'm going to apply it for 6.12 later.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-06 12:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-06  9:34 [PATCH RFC] ALSA: IEC958 definition for consumer status channel update Jerome Brunet
2024-09-06 12:25 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®