* Re: [PATCH] irqchip: fixed S3 could not resume after suspend
[not found] <tencent_7DFDDF87297476D86084241FE91E1E9D950A@qq.com>
@ 2021-04-09 10:38 ` Marc Zyngier
0 siblings, 0 replies; only message in thread
From: Marc Zyngier @ 2021-04-09 10:38 UTC (permalink / raw)
To: 414777006; +Cc: tglx, linux-kernel, Mengguang Peng
On Fri, 09 Apr 2021 11:10:09 +0100,
414777006@qq.com wrote:
>
> From: Mengguang Peng <pengmengguang@phytium.com.cn>
>
> On arm64 platform, found that the machine could not wake up after suspend,
> this patch updates the its suspend and resume handling code.
>
> - Add a variable named ctlr_save in struct rdists.
> - When suspend, save the value of GICR_CTLR to memmory
> in its_save_disable().
> - When resume, write the value of memory saved to GICR_CTLR
> in its_restore_enable().
This really is the kind of things that must be handled by firmware.
How comes yours doesn't handle it?
That is what you should be fixing. See the ATF code for a (working)
reference implementation
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] only message in thread